chrome/chrome_common.gypi - Issue 23257005: Move Feature and Manifest to top-level extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 23257005: Move Feature and Manifest to top-level extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 7457bcfd67cf02fc20e0e43c7a18b8eefcd2f2ab..b1f09fa97f428d4ec553a982836377b0492eb986 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -74,12 +74,16 @@

'../extensions/common/extension_resource.h',

'../extensions/common/extensions_client.cc',

'../extensions/common/extensions_client.h',

+ '../extensions/common/features/feature.cc',

+ '../extensions/common/features/feature.h',

'../extensions/common/features/feature_provider.cc',

'../extensions/common/features/feature_provider.h',

'../extensions/common/id_util.cc',

'../extensions/common/id_util.h',

'../extensions/common/install_warning.cc',

'../extensions/common/install_warning.h',

+ '../extensions/common/manifest.cc',

+ '../extensions/common/manifest.h',

'../extensions/common/manifest_constants.cc',

'../extensions/common/manifest_constants.h',

'../extensions/common/matcher/regex_set_matcher.cc',

@@ -251,8 +255,6 @@

'common/extensions/features/base_feature_provider.h',

'common/extensions/features/complex_feature.cc',

'common/extensions/features/complex_feature.h',

- 'common/extensions/features/feature.cc',

- 'common/extensions/features/feature.h',

'common/extensions/features/feature_channel.cc',

'common/extensions/features/feature_channel.h',

'common/extensions/features/manifest_feature.cc',

@@ -263,8 +265,6 @@

'common/extensions/features/simple_feature.h',

'common/extensions/incognito_handler.cc',

'common/extensions/incognito_handler.h',

- 'common/extensions/manifest.cc',

- 'common/extensions/manifest.h',

'common/extensions/manifest_handler.cc',

'common/extensions/manifest_handler.h',

'common/extensions/manifest_handler_helpers.cc',

« no previous file with comments | « chrome/browser/ui/webui/policy_ui.cc ('k') | chrome/common/extensions/api/commands/commands_handler.h » ('j') | no next file with comments »