gtk: Fix use after free

gtk: Fix use after free

This undoes r132498, which I'm pretty sure was barking up the wrong tree.

The issue in the bug is that the model is cleared and the popup is /hidden/ (not destroyed), but still has events queued up. LineFromY does attempt to sanitize the result (in case the model has changed without the UI having a chance to catch up), but doesn't handle an empty model.

BUG=123530
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219636

[Elliot Glaysher, 2013-08-15 19:45:39]

lgtm

[commit-bot: I haz the power, 2013-08-15 22:50:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/23257002/19001

[commit-bot: I haz the power, 2013-08-15 23:24:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Jered, 2013-08-16 21:14:30]

https://codereview.chromium.org/23257002/diff/19001/chrome/browser/ui/gtk/omn...
File chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc (right):

https://codereview.chromium.org/23257002/diff/19001/chrome/browser/ui/gtk/omn...
chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc:464: DCHECK_NE(0,
model_->result().size());
should be 0U

[commit-bot: I haz the power, 2013-08-26 17:47:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/23257002/44001

[commit-bot: I haz the power, 2013-08-26 23:14:57]

Change committed as 219636