Issue 23252008: Get rid of ConvertFieldToDescriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23252008: Get rid of ConvertFieldToDescriptor. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest

Modified:
7 years, 3 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Get rid of ConvertFieldToDescriptor. This CL additionally fixes up the attributes for FIELD and CONSTANT in SetLocalPropertyIgnoreAttributes. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16333

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressed comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -105 lines)			Patch
M	src/objects.h	View		6 chunks	+9 lines, -12 lines	0 comments	Download
M	src/objects.cc	View	1 2	16 chunks	+112 lines, -85 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://codereview.chromium.org/23252008/diff/4001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23252008/diff/4001/src/objects.cc#newcode4130 src/objects.cc:4130: break; Nit: use if-else instead

7 years, 3 months ago (2013-08-26 15:13:39 UTC) #2

Toon Verwaest

Addressed comment. https://codereview.chromium.org/23252008/diff/4001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23252008/diff/4001/src/objects.cc#newcode4130 src/objects.cc:4130: break; On 2013/08/26 15:13:39, rossberg wrote: > ...

7 years, 3 months ago (2013-08-26 15:21:27 UTC) #3

Toon Verwaest

7 years, 3 months ago (2013-08-26 15:30:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r16333 (presubmit successful).

Expand Messages | Collapse Messages