Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 23245004: Added UMA instrumentation for site-instrumented user timing marks and measures (Closed)

Created:
7 years, 4 months ago by Pat Meenan
Modified:
7 years, 4 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Added UMA instrumentation for site-instrumented user timing marks and measures Added UMA histograms for each performance.mark (PLT.UserTiming_Mark) and merformance.measure (PLT.UserTiming_MeasureDuration) that were instrumented by pages. Entry points were also exposed that measure the last mark on a page as well as if a page was instrumented for user timing so that the Chrome side of the code can report UMA's to track those. The last mark (PLT.UserTiming_LastMark) is useful in cases where sites instrument a bunch of things they want to track and it lets you know when the last one of those happened (like all of the above-the-fold images finished loading). Knowing if a page was instrumented (PLT.UserTiming_Instrumented) with user timing will let us track adoption over time. The Chrome-side of the code will be uploaded after the blink patch lands and is included in the blink milestone used by Chrome. BUG=262567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156481

Patch Set 1 #

Patch Set 2 : Simplified significantly and removed use tracking and lastMark UMAs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/page/PerformanceUserTiming.cpp View 1 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Pat Meenan
It turns out that someone had already plumbed UMA histograms into blink so adding the ...
7 years, 4 months ago (2013-08-16 16:37:14 UTC) #1
James Simonsen
We already have a use counter in WebCore.FeatureObserver. It's UnprefixedUserTiming. You can see it here: ...
7 years, 4 months ago (2013-08-16 22:17:02 UTC) #2
Pat Meenan
I removed the usage reporting (since it is already handled) and also removed the tracking ...
7 years, 4 months ago (2013-08-17 11:58:08 UTC) #3
tonyg
lgtm Thanks :)
7 years, 4 months ago (2013-08-17 14:14:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmeenan@chromium.org/23245004/5001
7 years, 4 months ago (2013-08-21 15:50:47 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 17:31:55 UTC) #6
Message was sent while issue was closed.
Change committed as 156481

Powered by Google App Engine
This is Rietveld 408576698