Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 23242015: Deflake fast/images/image-zoom-to-{25,500}.html (Closed)

Created:
7 years, 4 months ago by tony
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Deflake fast/images/image-zoom-to-{25,500}.html The tests were flaky on Linux because resizing the window is async in GTK+. If we haven't finished resizing, queue another resize event so we check again. BUG=276759 TBR=dominicc@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156531

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -69 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/images/image-zoom-to-25.html View 1 chunk +39 lines, -32 lines 0 comments Download
M LayoutTests/fast/images/image-zoom-to-500.html View 1 chunk +39 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/23242015/3001
7 years, 4 months ago (2013-08-21 23:19:27 UTC) #1
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-21 23:38:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/23242015/3001
7 years, 4 months ago (2013-08-21 23:40:03 UTC) #3
commit-bot: I haz the power
Commit queue failed due to new patchset.
7 years, 4 months ago (2013-08-22 01:04:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/23242015/18001
7 years, 4 months ago (2013-08-22 01:04:28 UTC) #5
commit-bot: I haz the power
Change committed as 156531
7 years, 4 months ago (2013-08-22 02:36:00 UTC) #6
dominicc (has gone to gerrit)
7 years, 4 months ago (2013-08-22 02:59:30 UTC) #7
Message was sent while issue was closed.
...and removes tabs to boot. LGTM.

Powered by Google App Engine
This is Rietveld 408576698