Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 23242008: Make failing webkit_tests fail android build. (Closed)

Created:
7 years, 4 months ago by Dirk Pranke
Modified:
7 years, 4 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Yaron, cmp, abarth-chromium, Peter Beverloo, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Make failing webkit_tests fail android build. Now that r156332 has landed in theory, the webkit_tests step should pass (since we're only running one test), and we should start trying to figure out how reliable the bots actually are. This change flips the bot config so that a failing webkit_tests step will cause the build to be red. If this turns out to be premature, I'll revert this change, but we should start gathering real data on what does and doesn't work now. R=ilevy@chromium.org, mbulach@chromium.org BUG=232044 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218489

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Dirk Pranke
7 years, 4 months ago (2013-08-19 20:23:35 UTC) #1
Dirk Pranke
adjusting reviewers based on the owners for this dir.
7 years, 4 months ago (2013-08-19 20:50:05 UTC) #2
Isaac (away)
lgtm https://chromiumcodereview.appspot.com/23242008/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://chromiumcodereview.appspot.com/23242008/diff/1/build/android/buildbot/bb_device_steps.py#newcode224 build/android/buildbot/bb_device_steps.py:224: ['--additional-expectations=%s' % os.path.join(CHROME_SRC, *f)]) Do you still need ...
7 years, 4 months ago (2013-08-19 21:16:23 UTC) #3
Peter Beverloo
lgtm!
7 years, 4 months ago (2013-08-19 21:16:50 UTC) #4
Dirk Pranke
On 2013/08/19 21:16:23, Isaac wrote: > lgtm > > https://chromiumcodereview.appspot.com/23242008/diff/1/build/android/buildbot/bb_device_steps.py > File build/android/buildbot/bb_device_steps.py (right): > ...
7 years, 4 months ago (2013-08-19 21:25:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/23242008/1
7 years, 4 months ago (2013-08-19 22:07:50 UTC) #6
bulach
lgtm, thanks!
7 years, 4 months ago (2013-08-20 10:09:07 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 14:37:05 UTC) #8
Message was sent while issue was closed.
Change committed as 218489

Powered by Google App Engine
This is Rietveld 408576698