Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 23226004: remove unused headers from sandbox_seccomp_bpf_linux.cc (Closed)

Created:
7 years, 3 months ago by Mostyn Bramley-Moore
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

remove unused headers from sandbox_seccomp_bpf_linux.cc sandbox_seccomp_bpf_linux.cc includes linux/audit.h and linux/filter.h but does not seem to use any of the macros or types defined within. BUG=279413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219630

Patch Set 1 #

Total comments: 2

Patch Set 2 : also remove linux/filter.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/common/sandbox_seccomp_bpf_linux.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@jln, piman: PTAL.
7 years, 3 months ago (2013-08-26 14:51:49 UTC) #1
jln (very slow on Chromium)
On 2013/08/26 14:51:49, Mostyn Bramley-Moore wrote: > @jln, piman: PTAL. lgtm (I removed piman, who ...
7 years, 3 months ago (2013-08-26 19:02:17 UTC) #2
jln (very slow on Chromium)
https://codereview.chromium.org/23226004/diff/1/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://codereview.chromium.org/23226004/diff/1/content/common/sandbox_seccomp_bpf_linux.cc#newcode9 content/common/sandbox_seccomp_bpf_linux.cc:9: #include <linux/filter.h> I don't think we'd need this one ...
7 years, 3 months ago (2013-08-26 19:02:39 UTC) #3
jln (very slow on Chromium)
Optional: open a bug and add a BUG= line. Removing headers often results in reverts, ...
7 years, 3 months ago (2013-08-26 19:04:38 UTC) #4
Mostyn Bramley-Moore
On 2013/08/26 19:04:38, Julien Tinnes wrote: > Optional: open a bug and add a BUG= ...
7 years, 3 months ago (2013-08-26 19:13:58 UTC) #5
Mostyn Bramley-Moore
https://codereview.chromium.org/23226004/diff/1/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://codereview.chromium.org/23226004/diff/1/content/common/sandbox_seccomp_bpf_linux.cc#newcode9 content/common/sandbox_seccomp_bpf_linux.cc:9: #include <linux/filter.h> On 2013/08/26 19:02:39, Julien Tinnes wrote: > ...
7 years, 3 months ago (2013-08-26 19:14:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/23226004/8001
7 years, 3 months ago (2013-08-26 19:32:04 UTC) #7
piman
lgtm
7 years, 3 months ago (2013-08-26 20:12:18 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-08-26 22:55:04 UTC) #9
Message was sent while issue was closed.
Change committed as 219630

Powered by Google App Engine
This is Rietveld 408576698