Source/core/html/HTMLMediaElement.cpp - Issue 23224011: HTMLMediaElement::createMediaControls should use AttachLazily

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 23224011: HTMLMediaElement::createMediaControls should use AttachLazily (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index a4c6dd039c2a38ea937de1332c5c25c7eb0de8f0..a7248da29ccdde4885384f6b266d7fb225b96897 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3688,7 +3688,7 @@ bool HTMLMediaElement::createMediaControls()

if (isFullscreen())

mediaControls->enteredFullscreen();

- ensureUserAgentShadowRoot()->appendChild(mediaControls, ASSERT_NO_EXCEPTION);

+ ensureUserAgentShadowRoot()->appendChild(mediaControls, ASSERT_NO_EXCEPTION, AttachLazily);

if (!controls() || !inDocument())

mediaControls->hide();

« no previous file with comments | « no previous file | no next file » | no next file with comments »