Add support for proguard preprocessing.

Add support for proguard preprocessing.

* Adds support for running proguard on our libraries
before they are added to the final release APK.
* Start using the proguard preprocessing for
third_party/guava.

BUG=272790
NOTRY=true
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217706

[nyquist, 2013-08-14 22:19:10]

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py
File build/android/gyp/proguard.py (right):

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:21: # proguard does its own dependency checking,
avoid that by deleting the output
Nit: Missing dot at end of comment.

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:24: proguard_cmd = [options.proguard_path,
'-injars', injars, '-outjars', outjars, '-libraryjars', libraryjars, '@' +
options.proguard_config]
Line too long.

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:30: parser.add_option('--proguard-path')
Add a help description to these?

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:33: parser.add_option('--proguard-config')
--proguard-config-file ?

https://codereview.chromium.org/23213002/diff/1/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/23213002/diff/1/build/java.gypi#newcode252
build/java.gypi:252:
'--proguard-path=<(android_sdk_root)/tools/proguard/bin/proguard.sh',
Add this to inputs? Or do we consider that never to be necessary for tools part
of the Android SDK, since other things are bound to change during SDK rolls?

https://codereview.chromium.org/23213002/diff/1/third_party/guava/proguard.pro
File third_party/guava/proguard.pro (right):

https://codereview.chromium.org/23213002/diff/1/third_party/guava/proguard.pr...
third_party/guava/proguard.pro:1: 
Nit: Unecessary newline.

https://codereview.chromium.org/23213002/diff/1/third_party/guava/proguard.pr...
third_party/guava/proguard.pro:22: -dontnote
com.google.common.cache.Striped64$Cell
Nit: Missing newline at end of file.

[nyquist, 2013-08-14 23:24:12]

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py
File build/android/gyp/proguard.py (right):

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:21: # proguard does its own dependency checking,
avoid that by deleting the output
On 2013/08/14 22:19:10, nyquist wrote:
> Nit: Missing dot at end of comment.

Done.

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:24: proguard_cmd = [options.proguard_path,
'-injars', injars, '-outjars', outjars, '-libraryjars', libraryjars, '@' +
options.proguard_config]
On 2013/08/14 22:19:10, nyquist wrote:
> Line too long.

Done.

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:30: parser.add_option('--proguard-path')
On 2013/08/14 22:19:10, nyquist wrote:
> Add a help description to these?

Done.

https://codereview.chromium.org/23213002/diff/1/build/android/gyp/proguard.py...
build/android/gyp/proguard.py:33: parser.add_option('--proguard-config')
On 2013/08/14 22:19:10, nyquist wrote:
> --proguard-config-file ?

Nope.

https://codereview.chromium.org/23213002/diff/1/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/23213002/diff/1/build/java.gypi#newcode252
build/java.gypi:252:
'--proguard-path=<(android_sdk_root)/tools/proguard/bin/proguard.sh',
On 2013/08/14 22:19:10, nyquist wrote:
> Add this to inputs? Or do we consider that never to be necessary for tools
part
> of the Android SDK, since other things are bound to change during SDK rolls?

Done.

https://codereview.chromium.org/23213002/diff/1/third_party/guava/proguard.pro
File third_party/guava/proguard.pro (right):

https://codereview.chromium.org/23213002/diff/1/third_party/guava/proguard.pr...
third_party/guava/proguard.pro:1: 
On 2013/08/14 22:19:10, nyquist wrote:
> Nit: Unecessary newline.

Done.

https://codereview.chromium.org/23213002/diff/1/third_party/guava/proguard.pr...
third_party/guava/proguard.pro:22: -dontnote
com.google.common.cache.Striped64$Cell
On 2013/08/14 22:19:10, nyquist wrote:
> Nit: Missing newline at end of file.

Done.

[Yaron, 2013-08-14 23:40:42]

lgtm

[nyquist, 2013-08-15 00:08:09]

lgtm

[commit-bot: I haz the power, 2013-08-15 00:09:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/23213002/9001

[commit-bot: I haz the power, 2013-08-15 00:12:09]

Change committed as 217706