Issue 23205011: [Android] Move getting the list of devices out of test_dispatcher.

Issue 23205011: [Android] Move getting the list of devices out of test_dispatcher. (Closed)

Created:
7 years, 4 months ago by frankf

Modified:
7 years, 4 months ago

Reviewers:
craigdh

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Move getting the list of devices out of test_dispatcher. BUG=272486 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218483

Patch Set 2 : Updated unit tests #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -83 lines)			Patch
M	build/android/pylib/base/test_dispatcher.py	View	1	5 chunks	+8 lines, -45 lines	0 comments	Download
M	build/android/pylib/base/test_dispatcher_unittest.py	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	build/android/pylib/gtest/setup.py	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	build/android/test_runner.py	View		12 chunks	+48 lines, -28 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

craigdh

https://codereview.chromium.org/23205011/diff/1/build/android/pylib/base/test_dispatcher.py File build/android/pylib/base/test_dispatcher.py (right): https://codereview.chromium.org/23205011/diff/1/build/android/pylib/base/test_dispatcher.py#newcode306 build/android/pylib/base/test_dispatcher.py:306: def RunTests(tests, runner_factory, devices, shard=True, Update the unittest as ...

7 years, 4 months ago (2013-08-19 18:22:34 UTC) #2

frankf

ptal https://codereview.chromium.org/23205011/diff/1/build/android/pylib/base/test_dispatcher.py File build/android/pylib/base/test_dispatcher.py (right): https://codereview.chromium.org/23205011/diff/1/build/android/pylib/base/test_dispatcher.py#newcode306 build/android/pylib/base/test_dispatcher.py:306: def RunTests(tests, runner_factory, devices, shard=True, Good catch. Done. ...

7 years, 4 months ago (2013-08-19 19:05:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/23205011/12001

7 years, 4 months ago (2013-08-19 20:10:27 UTC) #5

Message was sent while issue was closed.

Change committed as 218483

Expand Messages | Collapse Messages