Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 23205006: Define proprietary_codecs=1 when branding==Chrome. (Closed)

Created:
7 years, 4 months ago by scherkus (not reviewing)
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Define proprietary_codecs=1 when branding==Chrome. Doing so removes the redundant checks for GOOGLE_CHROME_BUILD when checking USE_PROPRIETARY_CODECS. BUG=274596 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218545

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix 'n rebase #

Patch Set 3 : rebase onto lkgr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
M build/common.gypi View 1 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/crypto/key_systems_info.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/crypto/key_systems_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_file_checker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_file_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/mime_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scherkus (not reviewing)
acolwell/ddorwin: take a look I tested all combinations of configs locally and things seem to ...
7 years, 4 months ago (2013-08-16 19:44:47 UTC) #1
ddorwin
LGTM. Thanks. https://codereview.chromium.org/23205006/diff/1/content/browser/media/encrypted_media_browsertest.cc File content/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/23205006/diff/1/content/browser/media/encrypted_media_browsertest.cc#newcode268 content/browser/media/encrypted_media_browsertest.cc:268: #endif Would you mind adding // defined(USE_PROPRIETARY_CODECS) ...
7 years, 4 months ago (2013-08-16 20:37:04 UTC) #2
scherkus (not reviewing)
thestig: OWNERS for chrome/* akalin: OWNERS for net/* acolwell: any thoughts? https://codereview.chromium.org/23205006/diff/1/content/browser/media/encrypted_media_browsertest.cc File content/browser/media/encrypted_media_browsertest.cc (right): ...
7 years, 4 months ago (2013-08-19 23:25:50 UTC) #3
acolwell GONE FROM CHROMIUM
lgtm. Should the third_party/ffmpeg gyp files be updated too?
7 years, 4 months ago (2013-08-19 23:52:18 UTC) #4
Lei Zhang
chrome/ lgtm
7 years, 4 months ago (2013-08-20 00:04:35 UTC) #5
scherkus (not reviewing)
On 2013/08/19 23:52:18, acolwell wrote: > lgtm. Should the third_party/ffmpeg gyp files be updated too? ...
7 years, 4 months ago (2013-08-20 01:52:30 UTC) #6
akalin
net owners lgtm
7 years, 4 months ago (2013-08-20 02:00:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/23205006/18001
7 years, 4 months ago (2013-08-20 16:59:24 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 20:22:26 UTC) #9
Message was sent while issue was closed.
Change committed as 218545

Powered by Google App Engine
This is Rietveld 408576698