Read directly from 'senc' box when 'senc' box is present

Read directly from 'senc' box when 'senc' box is present

BUG=645283
Committed: https://crrev.com/faf1ece408aa6fe78ac6a6cbe283b09ce1c3bf14
Cr-Commit-Position: refs/heads/master@{#424243}

[kqyang, 2016-09-08 22:58:29]

kqyang@chromium.org changed reviewers:
+ ddorwin@chromium.org

[kqyang, 2016-09-08 22:58:29]

Please review!

[kqyang, 2016-09-15 21:32:55]

Description was changed from

==========
Read directly from 'senc' box when 'senc' box is present

BUG=645283
==========

to

==========
Read directly from 'senc' box when 'senc' box is present

BUG=645283
==========

[kqyang, 2016-09-15 21:32:56]

kqyang@chromium.org changed reviewers:
+ tinskip@chromium.org

[kqyang, 2016-09-15 22:06:32]

Please review!

https://codereview.chromium.org/2320043005/diff/1/media/formats/mp4/box_defin...
File media/formats/mp4/box_definitions.cc (right):

https://codereview.chromium.org/2320043005/diff/1/media/formats/mp4/box_defin...
media/formats/mp4/box_definitions.cc:1215:
reader->MaybeReadChild(&sample_encryption));
This line loads 'senc' box if it is present. 

It is in the packager cl but somehow got lost when the change was integrated to
Chromium.

With this change, we will load sample encryption information from 'senc' box if
it is available; this avoids loading 'saiz' and 'saio' boxes and caching buffer
data for reading sample encryption information later.

[tinskip1, 2016-10-04 00:47:05]

lgtm

[kqyang, 2016-10-06 19:06:16]

I am planning to submit this change at the end of day today. If there is any
concern, please let me know.

[kqyang, 2016-10-07 00:58:17]

The CQ bit was checked by kqyang@chromium.org

[commit-bot: I haz the power, 2016-10-07 00:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 00:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 00:58:37]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[kqyang, 2016-10-07 17:20:10]

ddorwin@, can you review this change? Thanks.

[kqyang, 2016-10-07 17:36:38]

kqyang@chromium.org changed reviewers:
+ xhwang@chromium.org

[kqyang, 2016-10-07 17:36:39]

+xhwang@ to review the change. Thanks.

[xhwang, 2016-10-07 18:31:27]

https://chromiumcodereview.appspot.com/2320043005/diff/1/media/test/pipeline_...
File media/test/pipeline_integration_test.cc (right):

https://chromiumcodereview.appspot.com/2320043005/diff/1/media/test/pipeline_...
media/test/pipeline_integration_test.cc:1956:
MAYBE_EME(EncryptedPlayback_MP4_CENC_SENC_NO_SAIO_Video)) {
Could you please add more comments here or in the README file about what's the
expectation when we have SAIO and when we don't have SAIO. People can always
find answers in the spec but it'd be really helpful if we have some high level
info here.

[kqyang, 2016-10-07 20:49:41]

Added comments and also renamed the test file.

PTAL

[xhwang, 2016-10-07 23:07:47]

lgtm

[kqyang, 2016-10-10 17:50:41]

The CQ bit was checked by kqyang@chromium.org

[kqyang, 2016-10-10 17:50:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tinskip@chromium.org
Link to the patchset: https://codereview.chromium.org/2320043005/#ps40001
(title: "Add the missing file")

[commit-bot: I haz the power, 2016-10-10 17:50:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 17:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 17:59:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kqyang, 2016-10-10 18:40:26]

The CQ bit was checked by kqyang@chromium.org

[kqyang, 2016-10-10 18:40:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
tinskip@chromium.org, xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2320043005/#ps60001
(title: "git cl format")

[commit-bot: I haz the power, 2016-10-10 18:40:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:20:21]

Description was changed from

==========
Read directly from 'senc' box when 'senc' box is present

BUG=645283
==========

to

==========
Read directly from 'senc' box when 'senc' box is present

BUG=645283
==========

[commit-bot: I haz the power, 2016-10-10 21:20:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-10 21:24:02]

Description was changed from

==========
Read directly from 'senc' box when 'senc' box is present

BUG=645283
==========

to

==========
Read directly from 'senc' box when 'senc' box is present

BUG=645283

Committed: https://crrev.com/faf1ece408aa6fe78ac6a6cbe283b09ce1c3bf14
Cr-Commit-Position: refs/heads/master@{#424243}
==========

[commit-bot: I haz the power, 2016-10-10 21:24:03]

Patchset 4 (id:??) landed as
https://crrev.com/faf1ece408aa6fe78ac6a6cbe283b09ce1c3bf14
Cr-Commit-Position: refs/heads/master@{#424243}