Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 23197003: Enable coverage when drawing to the stencil buffer. (Closed)

Created:
7 years, 4 months ago by f(malita)
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Enable coverage when drawing to the stencil buffer. Currently, we set kEmitTransBlack_BlendOptFlag when drawing to the stencil buffer - but that prevents masks from being drawn correctly as they receive full coverage and no fragments get discarded. R=robertphillips@google.com,bsalomon@google.com Committed: http://code.google.com/p/skia/source/detail?r=10745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrDrawState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
f(malita)
7 years, 4 months ago (2013-08-15 12:53:43 UTC) #1
bsalomon
lgtm
7 years, 4 months ago (2013-08-15 13:28:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/23197003/1
7 years, 4 months ago (2013-08-15 13:32:44 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 18:16:45 UTC) #4
Message was sent while issue was closed.
Change committed as 10745

Powered by Google App Engine
This is Rietveld 408576698