Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 23192004: Fixes for factory GM. (Closed)

Created:
7 years, 4 months ago by scroggo
Modified:
7 years, 4 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixes for factory GM. Skip cross process pipe playback in gm/factory.cpp. Add a new flag to gm.h to skip only this form of pipe playback. In gmmain.cpp, use a bitmap encoder function for serialization that stores the encoded data if present, and use a bitmap decoder on deserialization. This allows gm/factory to work through serialization. Also respect the new pipe skipping flag. BUG=https://code.google.com/p/skia/issues/detail?id=1231 Committed: http://code.google.com/p/skia/source/detail?r=10786

Patch Set 1 #

Patch Set 2 : Be more specific about what to skip. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M gm/factory.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M gm/gm.h View 1 chunk +8 lines, -7 lines 0 comments Download
M gm/gmmain.cpp View 1 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
7 years, 4 months ago (2013-08-15 21:26:52 UTC) #1
borenet
This LGTM but I'm not at all familiar with what this code does or why ...
7 years, 4 months ago (2013-08-16 19:07:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/23192004/3001
7 years, 4 months ago (2013-08-16 19:10:54 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 19:18:18 UTC) #4
Message was sent while issue was closed.
Change committed as 10786

Powered by Google App Engine
This is Rietveld 408576698