Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1916)

Unified Diff: content/browser/media/webrtc_internals.cc

Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/webrtc_internals.cc
diff --git a/content/browser/media/webrtc_internals.cc b/content/browser/media/webrtc_internals.cc
index f8bcdc3d32136a5fc7e02731963c92994d7cfb0b..e94447a3e0a589896c756f5e39cb5b3b49686974 100644
--- a/content/browser/media/webrtc_internals.cc
+++ b/content/browser/media/webrtc_internals.cc
@@ -65,7 +65,7 @@ void WebRTCInternals::OnAddPeerConnection(int render_process_id,
dict->SetString("url", url);
peer_connection_data_.Append(dict);
- if (observers_.size() > 0)
+ if (observers_.might_have_observers())
SendUpdate("addPeerConnection", dict);
}
@@ -85,7 +85,7 @@ void WebRTCInternals::OnRemovePeerConnection(ProcessId pid, int lid) {
peer_connection_data_.Remove(i, NULL);
- if (observers_.size() > 0) {
+ if (observers_.might_have_observers()) {
base::DictionaryValue id;
id.SetInteger("pid", static_cast<int>(pid));
id.SetInteger("lid", lid);
@@ -123,7 +123,7 @@ void WebRTCInternals::OnUpdatePeerConnection(
log_entry->SetString("value", value);
log->Append(log_entry);
- if (observers_.size() > 0) {
+ if (observers_.might_have_observers()) {
base::DictionaryValue update;
update.SetInteger("pid", static_cast<int>(pid));
update.SetInteger("lid", lid);
@@ -138,7 +138,7 @@ void WebRTCInternals::OnUpdatePeerConnection(
void WebRTCInternals::OnAddStats(base::ProcessId pid, int lid,
const base::ListValue& value) {
- if (observers_.size() == 0)
+ if (!observers_.might_have_observers())
return;
base::DictionaryValue dict;
@@ -165,7 +165,7 @@ void WebRTCInternals::RemoveObserver(WebRTCInternalsUIObserver *observer) {
}
void WebRTCInternals::SendAllUpdates() {
- if (observers_.size() > 0)
+ if (observers_.might_have_observers())
SendUpdate("updateAllPeerConnections", &peer_connection_data_);
}
@@ -184,7 +184,7 @@ void WebRTCInternals::StopRtpRecording() {
}
void WebRTCInternals::SendUpdate(const string& command, base::Value* value) {
- DCHECK_GT(observers_.size(), (size_t)0);
+ DCHECK(observers_.might_have_observers());
FOR_EACH_OBSERVER(WebRTCInternalsUIObserver,
observers_,
@@ -216,7 +216,7 @@ void WebRTCInternals::OnRendererExit(int render_process_id) {
record->GetInteger("rid", &this_rid);
if (this_rid == render_process_id) {
- if (observers_.size() > 0) {
+ if (observers_.might_have_observers()) {
int lid = 0, pid = 0;
record->GetInteger("lid", &lid);
record->GetInteger("pid", &pid);
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/notification_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698