Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3576)

Unified Diff: chrome/browser/ui/panels/display_settings_provider.cc

Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/status_icons/status_icon.cc ('k') | chrome/browser/ui/panels/panel_mouse_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/display_settings_provider.cc
diff --git a/chrome/browser/ui/panels/display_settings_provider.cc b/chrome/browser/ui/panels/display_settings_provider.cc
index adf5ff25e896fd588a77bc83935ffb96f47e0838..42d76cc0ebceb78088f8641ab0f4e6edd2cc9af5 100644
--- a/chrome/browser/ui/panels/display_settings_provider.cc
+++ b/chrome/browser/ui/panels/display_settings_provider.cc
@@ -43,9 +43,10 @@ void DisplaySettingsProvider::RemoveDesktopBarObserver(
void DisplaySettingsProvider::AddFullScreenObserver(
FullScreenObserver* observer) {
is_full_screen_ = IsFullScreen();
+ bool already_started = full_screen_observers_.might_have_observers();
full_screen_observers_.AddObserver(observer);
- if (full_screen_observers_.size() == 1 && NeedsPeriodicFullScreenCheck()) {
+ if (!already_started && NeedsPeriodicFullScreenCheck()) {
full_screen_mode_timer_.Start(FROM_HERE,
base::TimeDelta::FromMilliseconds(kFullScreenModeCheckIntervalMs),
base::Bind(&DisplaySettingsProvider::CheckFullScreenMode,
@@ -58,7 +59,7 @@ void DisplaySettingsProvider::RemoveFullScreenObserver(
FullScreenObserver* observer) {
full_screen_observers_.RemoveObserver(observer);
- if (full_screen_observers_.size() == 0)
+ if (!full_screen_observers_.might_have_observers())
full_screen_mode_timer_.Stop();
}
« no previous file with comments | « chrome/browser/status_icons/status_icon.cc ('k') | chrome/browser/ui/panels/panel_mouse_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698