chrome/browser/policy/policy_service_impl.cc - Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_service_impl.cc

Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure merge Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/policy/policy_service_impl.cc

diff --git a/chrome/browser/policy/policy_service_impl.cc b/chrome/browser/policy/policy_service_impl.cc

index 6af760556e16a33db5ac140f43e2f306e18caddb..2cfdcbbd1341cf92b69518954643584d5bc255d7 100644

--- a/chrome/browser/policy/policy_service_impl.cc

+++ b/chrome/browser/policy/policy_service_impl.cc

@@ -56,7 +56,7 @@ void PolicyServiceImpl::RemoveObserver(PolicyDomain domain,

return;

}

it->second->RemoveObserver(observer);

- if (it->second->size() == 0) {

+ if (!it->second->might_have_observers()) {

delete it->second;

observers_.erase(it);

}

« no previous file with comments | « chrome/browser/net/pref_proxy_config_tracker_impl.cc ('k') | chrome/browser/status_icons/status_icon.cc » ('j') | no next file with comments »