chrome/browser/chromeos/cros/network_library_impl_base.cc - Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros/network_library_impl_base.cc

Issue 23190045: Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure merge Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/chromeos/network/network_icon_animation.cc ('k') | chrome/browser/download/download_path_reservation_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/cros/network_library_impl_base.cc

diff --git a/chrome/browser/chromeos/cros/network_library_impl_base.cc b/chrome/browser/chromeos/cros/network_library_impl_base.cc

index 6d38e0236e3c1e4303c81c9b653f3813169581d7..9b169a55c87a4b7494c0ebc4ff76208d14a2de8c 100644

--- a/chrome/browser/chromeos/cros/network_library_impl_base.cc

+++ b/chrome/browser/chromeos/cros/network_library_impl_base.cc

@@ -127,7 +127,7 @@ void NetworkLibraryImplBase::RemoveNetworkObserver(

network_observers_.find(service_path);

if (map_iter != network_observers_.end()) {

map_iter->second->RemoveObserver(observer);

- if (!map_iter->second->size()) {

+ if (!map_iter->second->might_have_observers()) {

MonitorNetworkStop(service_path);

delete map_iter->second;

network_observers_.erase(map_iter);

@@ -141,7 +141,7 @@ void NetworkLibraryImplBase::RemoveObserverForAllNetworks(

NetworkObserverMap::iterator map_iter = network_observers_.begin();

while (map_iter != network_observers_.end()) {

map_iter->second->RemoveObserver(observer);

- if (!map_iter->second->size()) {

+ if (!map_iter->second->might_have_observers()) {

MonitorNetworkStop(map_iter->first);

delete map_iter->second;

network_observers_.erase(map_iter++);