Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: media/filters/decrypting_audio_decoder.cc

Issue 2318933008: media: Update logging to display the missing keyId (Closed)
Patch Set: add DAD Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/decrypting_demuxer_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/decrypting_audio_decoder.cc
diff --git a/media/filters/decrypting_audio_decoder.cc b/media/filters/decrypting_audio_decoder.cc
index 69020c4cc076792580c11617d5d2a8294478d6c1..045047fdd544870c39a96e0f7d75dddd53ad1a3e 100644
--- a/media/filters/decrypting_audio_decoder.cc
+++ b/media/filters/decrypting_audio_decoder.cc
@@ -13,6 +13,7 @@
#include "base/location.h"
#include "base/logging.h"
#include "base/single_thread_task_runner.h"
+#include "base/strings/string_number_conversions.h"
#include "media/base/audio_buffer.h"
#include "media/base/audio_decoder_config.h"
#include "media/base/audio_timestamp_helper.h"
@@ -264,8 +265,12 @@ void DecryptingAudioDecoder::DeliverFrame(
}
if (status == Decryptor::kNoKey) {
- DVLOG(2) << "DeliverFrame() - kNoKey";
- MEDIA_LOG(DEBUG, media_log_) << GetDisplayName() << ": no key";
+ std::string key_id =
+ scoped_pending_buffer_to_decode->decrypt_config()->key_id();
+ std::string missing_key_id = base::HexEncode(key_id.data(), key_id.size());
+ DVLOG(1) << "DeliverFrame() - no key for key ID " << missing_key_id;
+ MEDIA_LOG(DEBUG, media_log_) << GetDisplayName() << ": no key for key ID "
+ << missing_key_id;
// Set |pending_buffer_to_decode_| back as we need to try decoding the
// pending buffer again when new key is added to the decryptor.
« no previous file with comments | « no previous file | media/filters/decrypting_demuxer_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698