sync/internal_api/sync_manager_impl.h - Issue 23189021: sync: Gracefully handle very early shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_manager_impl.h

Issue 23189021: sync: Gracefully handle very early shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Retry: sync non-blocking early shutdown Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/sync_manager_impl.h

diff --git a/sync/internal_api/sync_manager_impl.h b/sync/internal_api/sync_manager_impl.h

index 03d66366c32e9186649df167a121f151241ae6e5..0283065f8a6fde76fa9ccd7c21c58752caca81d0 100644

--- a/sync/internal_api/sync_manager_impl.h

+++ b/sync/internal_api/sync_manager_impl.h

@@ -81,7 +81,8 @@ class SYNC_EXPORT_PRIVATE SyncManagerImpl :

scoped_ptr<UnrecoverableErrorHandler> unrecoverable_error_handler,

ReportUnrecoverableErrorFunction

report_unrecoverable_error_function,

- bool use_oauth2_token) OVERRIDE;

+ bool use_oauth2_token,

+ CancelationSignal* cancelation_signal) OVERRIDE;

virtual void ThrowUnrecoverableError() OVERRIDE;

virtual ModelTypeSet InitialSyncEndedTypes() OVERRIDE;

virtual ModelTypeSet GetTypesWithEmptyProgressMarkerToken(

@@ -106,7 +107,6 @@ class SYNC_EXPORT_PRIVATE SyncManagerImpl :

virtual void RemoveObserver(SyncManager::Observer* observer) OVERRIDE;

virtual SyncStatus GetDetailedStatus() const OVERRIDE;

virtual void SaveChanges() OVERRIDE;

- virtual void StopSyncingForShutdown() OVERRIDE;

virtual void ShutdownOnSyncThread() OVERRIDE;

virtual UserShare* GetUserShare() OVERRIDE;

virtual const std::string cache_guid() OVERRIDE;