Upgrades lcov to 1.10, removes lcov-1.9

Upgrades lcov to 1.10, removes lcov-1.9

BUG=273902
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218387

[gkanwar1, 2013-08-15 22:39:33]

This change appears to pass all trybots (except mac_rel, which is failing on
telemetry_unittests globally).

Brett, ptal? Thanks.

[brettw, 2013-08-16 06:05:49]

lgtm

[gkanwar1, 2013-08-16 16:43:58]

On 2013/08/16 06:05:49, brettw wrote:
> lgtm

Thanks, CQing.

[commit-bot: I haz the power, 2013-08-16 16:44:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23189008/1

[commit-bot: I haz the power, 2013-08-16 17:00:43]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[gkanwar1, 2013-08-16 17:03:33]

On 2013/08/16 17:00:43, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Looks like I'm missing an LGTM for tools/checklicenses... Adding Pawel for
review.

[Paweł Hajdan Jr., 2013-08-16 18:12:11]

LGTM, nice cleanup.

https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
tools/checklicenses/checklicenses.py:241: 'third_party/lcov': [  #
http://crbug.com/98304
nit: And now you can remove the bug reference, because this change fixes the
bug!

https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
tools/checklicenses/checklicenses.py:244:
'third_party/lcov/contrib/galaxy/genflat.pl': [
nit: This entry can be removed now, it's a subset of the above line.

[gkanwar1, 2013-08-16 19:22:43]

Fixed the nits. I'm still getting the following when running checklicenses.py.
It looks like this is because there is not license at the top of the files in
the lcov distribution, it's all in the COPYING file.

'third_party/lcov/bin/updateversion.pl' has non-whitelisted license 'UNKNOWN'
'third_party/lcov/bin/install.sh' has non-whitelisted license 'UNKNOWN'
'third_party/lcov/contrib/galaxy/conglomerate_functions.pl' has non-whitelisted
license 'UNKNOWN'
'third_party/lcov/contrib/galaxy/gen_makefile.sh' has non-whitelisted license
'UNKNOWN'
'third_party/lcov/example/gauss.h' has non-whitelisted license 'UNKNOWN'
'third_party/lcov/example/iterate.h' has non-whitelisted license 'UNKNOWN'
'third_party/lcov/example/methods/gauss.c' has non-whitelisted license 'UNKNOWN'
'third_party/lcov/example/methods/iterate.c' has non-whitelisted license
'UNKNOWN'

https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
tools/checklicenses/checklicenses.py:241: 'third_party/lcov': [  #
http://crbug.com/98304
On 2013/08/16 18:12:11, Paweł Hajdan Jr. wrote:
> nit: And now you can remove the bug reference, because this change fixes the
> bug!

Done.

https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
tools/checklicenses/checklicenses.py:244:
'third_party/lcov/contrib/galaxy/genflat.pl': [
On 2013/08/16 18:12:11, Paweł Hajdan Jr. wrote:
> nit: This entry can be removed now, it's a subset of the above line.

Done.

[gkanwar1, 2013-08-16 19:23:14]

On 2013/08/16 19:22:43, gkanwar1 wrote:
> Fixed the nits. I'm still getting the following when running checklicenses.py.
> It looks like this is because there is not license at the top of the files in
> the lcov distribution, it's all in the COPYING file.
> 
> 'third_party/lcov/bin/updateversion.pl' has non-whitelisted license 'UNKNOWN'
> 'third_party/lcov/bin/install.sh' has non-whitelisted license 'UNKNOWN'
> 'third_party/lcov/contrib/galaxy/conglomerate_functions.pl' has
non-whitelisted
> license 'UNKNOWN'
> 'third_party/lcov/contrib/galaxy/gen_makefile.sh' has non-whitelisted license
> 'UNKNOWN'
> 'third_party/lcov/example/gauss.h' has non-whitelisted license 'UNKNOWN'
> 'third_party/lcov/example/iterate.h' has non-whitelisted license 'UNKNOWN'
> 'third_party/lcov/example/methods/gauss.c' has non-whitelisted license
'UNKNOWN'
> 'third_party/lcov/example/methods/iterate.c' has non-whitelisted license
> 'UNKNOWN'
> 
>
https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
> File tools/checklicenses/checklicenses.py (right):
> 
>
https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
> tools/checklicenses/checklicenses.py:241: 'third_party/lcov': [  #
> http://crbug.com/98304
> On 2013/08/16 18:12:11, Paweł Hajdan Jr. wrote:
> > nit: And now you can remove the bug reference, because this change fixes the
> > bug!
> 
> Done.
> 
>
https://codereview.chromium.org/23189008/diff/1/tools/checklicenses/checklice...
> tools/checklicenses/checklicenses.py:244:
> 'third_party/lcov/contrib/galaxy/genflat.pl': [
> On 2013/08/16 18:12:11, Paweł Hajdan Jr. wrote:
> > nit: This entry can be removed now, it's a subset of the above line.
> 
> Done.

To be clear -- Pawel, can you please confirm that these errors are okay, and I
should proceed? Or is there some way I should fix this?

[Paweł Hajdan Jr., 2013-08-16 19:40:43]

Ah, so thew errors are still there - well that needs to be fixed.

Please restore the UNKNOWN suppression, and remove the bug reference from the
commit message (this doesn't change anything wrt the bug).

Then keep the GPL exclusion as minimal as possible, not lcov-wide.

"not lgtm" in the current shape

[gkanwar1, 2013-08-16 20:36:32]

On 2013/08/16 19:40:43, Paweł Hajdan Jr. wrote:
> Ah, so thew errors are still there - well that needs to be fixed.
> 
> Please restore the UNKNOWN suppression, and remove the bug reference from the
> commit message (this doesn't change anything wrt the bug).
> 
> Then keep the GPL exclusion as minimal as possible, not lcov-wide.
> 
> "not lgtm" in the current shape

Ah, I think I was misunderstanding how the checklicenses script worked. Reverted
the back to 'UNKNOWN'. Now checklicenses.py appears to be happy with the lcov
directory.

[Paweł Hajdan Jr., 2013-08-16 21:02:48]

LGTM

Could you explain more what created the confusion with checklicenses, so that I
may have a chance to fix it or at least improve?

[gkanwar1, 2013-08-16 21:06:05]

On 2013/08/16 21:02:48, Paweł Hajdan Jr. wrote:
> LGTM
> 
> Could you explain more what created the confusion with checklicenses, so that
I
> may have a chance to fix it or at least improve?

Thanks. I'm going to wait for the trybots to clear then CQ.

The confusion was mostly because I'm not familiar with what the checklicenses.py
script does. I thought it was checking the lcov directory for a LICENSE or
COPYING file. This version has a COPYING file with GPL v2, so I assumed I should
update the entry in checklicenses.py.

[gkanwar1, 2013-08-17 02:24:12]

On 2013/08/16 21:06:05, gkanwar1 wrote:
> On 2013/08/16 21:02:48, Paweł Hajdan Jr. wrote:
> > LGTM
> > 
> > Could you explain more what created the confusion with checklicenses, so
that
> I
> > may have a chance to fix it or at least improve?
> 
> Thanks. I'm going to wait for the trybots to clear then CQ.
> 
> The confusion was mostly because I'm not familiar with what the
checklicenses.py
> script does. I thought it was checking the lcov directory for a LICENSE or
> COPYING file. This version has a COPYING file with GPL v2, so I assumed I
should
> update the entry in checklicenses.py.

win_rel triggered tests appears to be an issue with the bot's connection to
https://chromium-swarm.appspot.com, unrelated to this change. I'll land this on
Monday, so I can put out fires if needed.

[commit-bot: I haz the power, 2013-08-19 16:55:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gkanwar@chromium.org/23189008/114001

[commit-bot: I haz the power, 2013-08-20 01:02:55]

Change committed as 218387