Reset viewport to implicit when @viewport is removed.

Reset viewport to implicit when @viewport is removed.

When m_propertySet was null after cascading @viewport rules (no rules added),
ViewportStyleResolver::resolve would be a no-op so that removing the last
@viewport rule through CSSOM would not have an effect. This is fixed by
re-setting to Implicit when removing the last @viewport rule.

Removed a stray ViewportStyleResolver::resolve call in viewportAsText that was
a no-op before the rest of this change, but resulted in always resetting the
viewport arguments with this fix.

BUG=276812
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156855

[kenneth.r.christiansen, 2013-08-21 08:28:35]

https://codereview.chromium.org/23185008/diff/1/LayoutTests/css3/device-adapt...
File LayoutTests/css3/device-adapt/viewport-delete-rule.html (right):

https://codereview.chromium.org/23185008/diff/1/LayoutTests/css3/device-adapt...
LayoutTests/css3/device-adapt/viewport-delete-rule.html:17: var t2 =
async_test("Check that @viewport rule is not applied after removal.");
Great to have this tested

https://codereview.chromium.org/23185008/diff/1/Source/core/css/resolver/View...
File Source/core/css/resolver/ViewportStyleResolver.cpp (right):

https://codereview.chromium.org/23185008/diff/1/Source/core/css/resolver/View...
Source/core/css/resolver/ViewportStyleResolver.cpp:86: if
(m_document->viewportArguments().type == ViewportArguments::CSSDeviceAdaptation)
{
Did you test if this is also an issue after my ->@viewport translation patch?

[rune, 2013-08-21 08:43:42]

On 2013/08/21 08:28:35, kenneth.r.christiansen wrote:
>
https://codereview.chromium.org/23185008/diff/1/LayoutTests/css3/device-adapt...
> File LayoutTests/css3/device-adapt/viewport-delete-rule.html (right):
> 
>
https://codereview.chromium.org/23185008/diff/1/LayoutTests/css3/device-adapt...
> LayoutTests/css3/device-adapt/viewport-delete-rule.html:17: var t2 =
> async_test("Check that @viewport rule is not applied after removal.");
> Great to have this tested
> 
>
https://codereview.chromium.org/23185008/diff/1/Source/core/css/resolver/View...
> File Source/core/css/resolver/ViewportStyleResolver.cpp (right):
> 
>
https://codereview.chromium.org/23185008/diff/1/Source/core/css/resolver/View...
> Source/core/css/resolver/ViewportStyleResolver.cpp:86: if
> (m_document->viewportArguments().type ==
ViewportArguments::CSSDeviceAdaptation)
> {
> Did you test if this is also an issue after my ->@viewport translation patch?

No. Looking at that patch, I see that you've removed "m_propertySet = 0", but I
can't see that the cascaded descriptors are reset anywhere else between style
resolves?

[kenneth.r.christiansen, 2013-08-21 09:24:40]

im fine with this patch, I just need to find out how to fix this in my own :-)

[Mike West, 2013-08-28 14:42:12]

Makes sense.

LGTM, as long as the trybots are happy.

[commit-bot: I haz the power, 2013-08-28 14:47:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/23185008/1

[commit-bot: I haz the power, 2013-08-28 16:13:56]

Change committed as 156855