Pretty-print the CL description during commit.

Pretty-print the CL description during commit.

Having "Description: 1234
\nR=bar@chromium.org\nReview">u'Foo\nBUG=1234
\nR=bar@chromium.org\nReview Url: baz'"
is not actually that useful in my experience. I'd rather be able to easily
read the final CL description that is being committed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=217834

[M-A Ruel, 2013-08-15 19:12:51]

https://codereview.chromium.org/23185006/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/23185006/diff/1/git_cl.py#newcode1672
git_cl.py:1672: for line in commit_desc.description.split('\n'):
What's the difference between this and "print commit_desc.description" ?

I don't recall why Evan decided to print repr() of it.

[agable, 2013-08-15 20:25:24]

Fixed.

https://codereview.chromium.org/23185006/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/23185006/diff/1/git_cl.py#newcode1672
git_cl.py:1672: for line in commit_desc.description.split('\n'):
On 2013/08/15 19:12:51, M-A Ruel wrote:
> What's the difference between this and "print commit_desc.description" ?
> 
> I don't recall why Evan decided to print repr() of it.

There's not; I was just being dumb.

There doesn't seem to be any reason to repr() it. It's much more helpful to have
the plain-text description available for the user to copy-paste into another
editor than a u'' for them to paste into... what python process?

[M-A Ruel, 2013-08-15 20:27:26]

lgtm with nit

https://codereview.chromium.org/23185006/diff/6001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/23185006/diff/6001/git_cl.py#newcode1671
git_cl.py:1671: print 'Description:\n', commit_desc.description
I'd prefer two separate lines.
print('Description:')
print(commit_desc.description)

[agable, 2013-08-15 20:29:16]

https://codereview.chromium.org/23185006/diff/6001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/23185006/diff/6001/git_cl.py#newcode1671
git_cl.py:1671: print 'Description:\n', commit_desc.description
On 2013/08/15 20:27:26, M-A Ruel wrote:
> I'd prefer two separate lines.
> print('Description:')
> print(commit_desc.description)

Fair enough, Done. Was just keeping the diff small.

[commit-bot: I haz the power, 2013-08-15 20:29:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/23185006/2

[M-A Ruel, 2013-08-15 20:31:28]

On 2013/08/15 20:29:16, Aaron Gable wrote:
> Fair enough, Done. Was just keeping the diff small.

Always prefer beautifying code[1] to minimizing diff.

[1] using God's definition of beautiful code. For whatever it means.

[commit-bot: I haz the power, 2013-08-15 20:31:41]

Change committed as 217834