Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 23181007: Add the "mfpmath=sse" compiler flag for ChromeOS devices. (Closed)

Created:
7 years, 4 months ago by Owen Lin
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add the "mfpmath=sse" compiler flag for ChromeOS devices. This is to preventng floating-point computations in the 80-bit precision on x87. Please see more details in: http://codereview.chromium.org/42340/patch/64/2085 BUG=261358 TEST=Play videos on Parrot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Owen Lin
PTAL
7 years, 4 months ago (2013-08-16 06:47:37 UTC) #1
Ami GONE FROM CHROMIUM
LGTM (though as you found out, we should probably be building with these flags for ...
7 years, 4 months ago (2013-08-16 15:52:37 UTC) #2
Ami GONE FROM CHROMIUM
On 2013/08/16 15:52:37, Ami Fischman wrote: > LGTM > > (though as you found out, ...
7 years, 4 months ago (2013-08-16 15:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/23181007/1
7 years, 4 months ago (2013-08-16 16:34:06 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=21028
7 years, 4 months ago (2013-08-16 16:44:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/23181007/1
7 years, 4 months ago (2013-08-16 16:57:20 UTC) #6
commit-bot: I haz the power
Change committed as 218068
7 years, 4 months ago (2013-08-16 19:54:55 UTC) #7
fbarchard
7 years, 4 months ago (2013-08-19 05:57:37 UTC) #8
Message was sent while issue was closed.
On 2013/08/16 19:54:55, I haz the power (commit-bot) wrote:
> Change committed as 218068

LGTM
Consider requiring SSE/SSE2 for media in general.

Powered by Google App Engine
This is Rietveld 408576698