Update the app launcher menu on profile name change.

chrome/browser/ui/app_list/app_list_view_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_view_delegate.h"
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 43 matching lines @@
 }  // namespace
 
 AppListViewDelegate::AppListViewDelegate(AppListControllerDelegate* controller,
                                          Profile* profile)
     : controller_(controller),
       profile_(profile),
       model_(NULL) {
   DCHECK(profile_);
   registrar_.Add(this, chrome::NOTIFICATION_GOOGLE_SIGNED_OUT,
                  content::Source<Profile>(profile_));
+  g_browser_process->profile_manager()->GetProfileInfoCache().AddObserver(this);
 }
 
 AppListViewDelegate::~AppListViewDelegate() {

[tapted, 2013/08/15 06:34:31]

Just be aware... I don't think this destructor is called except when switching
profiles, because the app list services are intentionally leaked. .. Which would
mean the observers will still be on the ProfileInfoCache when it is destroyed.
But I think this is normal. ~ObserverList() only DCHECKs that the observers are
gone if you ask it to

   if (signin_delegate_)
     signin_delegate_->RemoveObserver(this);
+  g_browser_process->
+      profile_manager()->GetProfileInfoCache().RemoveObserver(this);
 }
 
 void AppListViewDelegate::OnProfileChanged() {
   model_->SetSignedIn(!signin_delegate_->NeedSignin());
   ProfileInfoCache& cache =
       g_browser_process->profile_manager()->GetProfileInfoCache();
   // Populate the current user details.
   size_t profile_index = cache.GetIndexOfProfileWithPath(profile_->GetPath());
   // The profile won't exist in the cache if the current app list profile is
   // being deleted.
@@ skipping 146 matching lines @@
 void AppListViewDelegate::OnSigninSuccess() {
   OnProfileChanged();
 }
 
 void AppListViewDelegate::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   OnProfileChanged();
 }
+
+void AppListViewDelegate::OnProfileAdded(const base::FilePath& profile_path) {
+  OnProfileChanged();

[tapted, 2013/08/15 06:34:31]

I don't think we need to do anything here

[calamity, 2013/08/15 09:16:46]

Done.

+}
+
+void AppListViewDelegate::OnProfileWillBeRemoved(
+    const base::FilePath& profile_path) {
+  OnProfileChanged();

[tapted, 2013/08/15 06:34:31]

This is currently handled in AppListServiceImpl::OnProfileWillBeRemoved() - I
don't think it should do anything here.

[calamity, 2013/08/15 09:16:46]

Done.

+}
+
+void AppListViewDelegate::OnProfileNameChanged(
+    const base::FilePath& profile_path,
+    const string16& old_profile_name) {

[tapted, 2013/08/15 06:34:31]

nit: base::string16

[calamity, 2013/08/15 09:16:46]

Done.

+  OnProfileChanged();

[tapted, 2013/08/15 07:15:54]

Probably also worth adding before this:

if (profile_->GetPath() != profile_path)
  return;

This makes it consistent with the filter applied to the notifications

[calamity, 2013/08/15 09:16:46]

Done.

+}