Issue 23174002: Fix crash when querying a runtime config that is defined in environment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23174002: Fix crash when querying a runtime config that is defined in environment (Closed)

Created:
7 years, 4 months ago by Kimmo Kinnunen

Modified:
7 years, 4 months ago

Reviewers:
humper, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix crash when querying a runtime config that is defined in environment Fix crash when querying a runtime config in case when there's no skia.conf file and the config variable is still defined in the environment. Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test. Previous version of the patch failed Windows build due to setenv usage. On Windows, use _putenv_s instead. BUG=skia:1494 Committed: http://code.google.com/p/skia/source/detail?r=10715

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -0 lines)			Patch
M	gyp/tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/utils/SkRTConf.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/utils/SkRTConf.cpp	View	4 chunks	+34 lines, -0 lines	0 comments	Download
A	tests/UnitTestTest.cpp	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kimmo Kinnunen

A fixed patch for review, previous one failed win build.

7 years, 4 months ago (2013-08-14 06:39:01 UTC) #1

Kimmo Kinnunen

On 2013/08/14 06:39:01, kkinnunen wrote: > A fixed patch for review, previous one failed win ...

7 years, 4 months ago (2013-08-14 06:39:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/23174002/1

7 years, 4 months ago (2013-08-14 13:12:52 UTC) #4

Message was sent while issue was closed.

Change committed as 10715

Expand Messages | Collapse Messages