Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 23173004: [SyncFS] Simplify MetadataDatabaseTest (Closed)

Created:
7 years, 4 months ago by tzik
Modified:
7 years, 4 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

[SyncFS] Simplify MetadataDatabaseTest BUG=240165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217796

Patch Set 1 #

Patch Set 2 : test fix #

Total comments: 2

Patch Set 3 : nitpick #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -235 lines) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 1 2 5 chunks +171 lines, -235 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTL
7 years, 4 months ago (2013-08-14 09:51:49 UTC) #1
kinuko
lgtm https://codereview.chromium.org/23173004/diff/3001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc (right): https://codereview.chromium.org/23173004/diff/3001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc#newcode221 chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:221: int size) { nit: indent
7 years, 4 months ago (2013-08-14 14:16:56 UTC) #2
nhiroki
lgtm
7 years, 4 months ago (2013-08-15 01:15:00 UTC) #3
tzik
https://codereview.chromium.org/23173004/diff/3001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc (right): https://codereview.chromium.org/23173004/diff/3001/chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc#newcode221 chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:221: int size) { On 2013/08/14 14:16:56, kinuko wrote: > ...
7 years, 4 months ago (2013-08-15 04:31:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/23173004/14001
7 years, 4 months ago (2013-08-15 04:32:05 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 15:16:32 UTC) #6
Message was sent while issue was closed.
Change committed as 217796

Powered by Google App Engine
This is Rietveld 408576698