Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23172003: Improve parallelization of CSP and XSSAuditor reporting tests. (Closed)

Created:
7 years, 4 months ago by Mike West
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, mkwst+watchlist_chromium.org, Tom Sepez, abarth-chromium, jww
Visibility:
Public.

Description

Improve parallelization of CSP and XSSAuditor reporting tests. This patch passes the test name along with the report, meaning that each test will write its own temporary file. This has the happy effect of allowing us to run `http/tests/security` tests while providing the `--fully-parallel` flag to the test runner. Ah, speed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -63 lines) Patch
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-and-enforce.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-only.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-only-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-only-from-header.php View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-scheme-relative.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-report.php View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/resources/go-to-echo-report.js View 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/resources/save-report.php View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/report-script-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/report-script-tag-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/report-script-tag-full-block.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Hi Jochen! Would you mind taking a look at this patch? -mike
7 years, 4 months ago (2013-08-16 14:14:14 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-16 14:18:37 UTC) #2
Mike West
+abarth, tsepez, jww: FYI.
7 years, 4 months ago (2013-08-16 14:24:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23172003/1
7 years, 4 months ago (2013-08-16 14:24:16 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 16:16:34 UTC) #5
Message was sent while issue was closed. 
Change committed as 156226

Powered by Google App Engine
This is Rietveld 408576698