Issue 23171022: [Android] Set sdk version and sdk root in GYP_DEFINES via envsetup.sh.

Issue 23171022: [Android] Set sdk version and sdk root in GYP_DEFINES via envsetup.sh. (Closed)

Created:
7 years, 4 months ago by Siva Chandra

Modified:
7 years, 4 months ago

Reviewers:
Yaron, Isaac (away), yfriedman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Set sdk version and sdk root in GYP_DEFINES via envsetup.sh. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219309

Patch Set 2 : Set the GYP_DEFINES only if the corresponding evn vars are overridden #

Total comments: 1

Patch Set 3 : make new env var local #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	build/android/envsetup_functions.sh	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yaron

https://codereview.chromium.org/23171022/diff/1/build/android/envsetup_functions.sh File build/android/envsetup_functions.sh (right): https://codereview.chromium.org/23171022/diff/1/build/android/envsetup_functions.sh#newcode252 build/android/envsetup_functions.sh:252: DEFINES+=" android_sdk_root=${ANDROID_SDK_ROOT}" Why do this? Just to simplify the ...

7 years, 4 months ago (2013-08-23 00:40:50 UTC) #2

Siva Chandra

PTAL. https://codereview.chromium.org/23171022/diff/1/build/android/envsetup_functions.sh File build/android/envsetup_functions.sh (right): https://codereview.chromium.org/23171022/diff/1/build/android/envsetup_functions.sh#newcode252 build/android/envsetup_functions.sh:252: DEFINES+=" android_sdk_root=${ANDROID_SDK_ROOT}" On 2013/08/23 00:40:50, Yaron wrote: > ...

7 years, 4 months ago (2013-08-23 00:58:28 UTC) #3

Yaron

lgtm https://codereview.chromium.org/23171022/diff/7001/build/android/envsetup_functions.sh File build/android/envsetup_functions.sh (right): https://codereview.chromium.org/23171022/diff/7001/build/android/envsetup_functions.sh#newcode226 build/android/envsetup_functions.sh:226: SDK_DEFINES="" Please change this to a local (local ...

7 years, 4 months ago (2013-08-23 01:18:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/23171022/14001

7 years, 4 months ago (2013-08-23 18:04:41 UTC) #5

Message was sent while issue was closed.

Change committed as 219309

Expand Messages | Collapse Messages