Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: webkit/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc

Issue 23167002: FileAPI: Rename SandboxContext to SandboxFileSystemBackendDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/browser/fileapi/sandbox_context.h" 5 #include "webkit/browser/fileapi/sandbox_file_system_backend_delegate.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/files/scoped_temp_dir.h" 9 #include "base/files/scoped_temp_dir.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
12 #include "base/message_loop/message_loop_proxy.h" 12 #include "base/message_loop/message_loop_proxy.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 #include "webkit/browser/fileapi/file_system_url.h" 15 #include "webkit/browser/fileapi/file_system_url.h"
16 #include "webkit/browser/fileapi/mock_file_system_options.h" 16 #include "webkit/browser/fileapi/mock_file_system_options.h"
17 17
18 namespace fileapi { 18 namespace fileapi {
19 19
20 namespace { 20 namespace {
21 21
22 FileSystemURL CreateFileSystemURL(const char* path) { 22 FileSystemURL CreateFileSystemURL(const char* path) {
23 const GURL kOrigin("http://foo/"); 23 const GURL kOrigin("http://foo/");
24 return FileSystemURL::CreateForTest( 24 return FileSystemURL::CreateForTest(
25 kOrigin, kFileSystemTypeTemporary, base::FilePath::FromUTF8Unsafe(path)); 25 kOrigin, kFileSystemTypeTemporary, base::FilePath::FromUTF8Unsafe(path));
26 } 26 }
27 27
28 } // namespace 28 } // namespace
29 29
30 class SandboxContextTest : public testing::Test { 30 class SandboxFileSystemBackendDelegateTest : public testing::Test {
31 protected: 31 protected:
32 virtual void SetUp() { 32 virtual void SetUp() {
33 ASSERT_TRUE(data_dir_.CreateUniqueTempDir()); 33 ASSERT_TRUE(data_dir_.CreateUniqueTempDir());
34 context_.reset(new SandboxContext( 34 delegate_.reset(new SandboxFileSystemBackendDelegate(
35 NULL /* quota_manager_proxy */, 35 NULL /* quota_manager_proxy */,
36 base::MessageLoopProxy::current().get(), 36 base::MessageLoopProxy::current().get(),
37 data_dir_.path(), 37 data_dir_.path(),
38 NULL /* special_storage_policy */, 38 NULL /* special_storage_policy */,
39 CreateAllowFileAccessOptions())); 39 CreateAllowFileAccessOptions()));
40 } 40 }
41 41
42 base::ScopedTempDir data_dir_; 42 base::ScopedTempDir data_dir_;
43 base::MessageLoop message_loop_; 43 base::MessageLoop message_loop_;
44 scoped_ptr<SandboxContext> context_; 44 scoped_ptr<SandboxFileSystemBackendDelegate> delegate_;
45 }; 45 };
46 46
47 TEST_F(SandboxContextTest, IsAccessValid) { 47 TEST_F(SandboxFileSystemBackendDelegateTest, IsAccessValid) {
48 // Normal case. 48 // Normal case.
49 EXPECT_TRUE(context_->IsAccessValid(CreateFileSystemURL("a"))); 49 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL("a")));
50 50
51 // Access to a path with parent references ('..') should be disallowed. 51 // Access to a path with parent references ('..') should be disallowed.
52 EXPECT_FALSE(context_->IsAccessValid(CreateFileSystemURL("a/../b"))); 52 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL("a/../b")));
53 53
54 // Access from non-allowed scheme should be disallowed. 54 // Access from non-allowed scheme should be disallowed.
55 EXPECT_FALSE(context_->IsAccessValid( 55 EXPECT_FALSE(delegate_->IsAccessValid(
56 FileSystemURL::CreateForTest( 56 FileSystemURL::CreateForTest(
57 GURL("unknown://bar"), kFileSystemTypeTemporary, 57 GURL("unknown://bar"), kFileSystemTypeTemporary,
58 base::FilePath::FromUTF8Unsafe("foo")))); 58 base::FilePath::FromUTF8Unsafe("foo"))));
59 59
60 // Access with restricted name should be disallowed. 60 // Access with restricted name should be disallowed.
61 EXPECT_FALSE(context_->IsAccessValid(CreateFileSystemURL("."))); 61 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL(".")));
62 EXPECT_FALSE(context_->IsAccessValid(CreateFileSystemURL(".."))); 62 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL("..")));
63 63
64 // This is also disallowed due to Windows XP parent path handling. 64 // This is also disallowed due to Windows XP parent path handling.
65 EXPECT_FALSE(context_->IsAccessValid(CreateFileSystemURL("..."))); 65 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL("...")));
66 66
67 // These are identified as unsafe cases due to weird path handling 67 // These are identified as unsafe cases due to weird path handling
68 // on Windows. 68 // on Windows.
69 EXPECT_FALSE(context_->IsAccessValid(CreateFileSystemURL(" .."))); 69 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL(" ..")));
70 EXPECT_FALSE(context_->IsAccessValid(CreateFileSystemURL(".. "))); 70 EXPECT_FALSE(delegate_->IsAccessValid(CreateFileSystemURL(".. ")));
71 71
72 // Similar but safe cases. 72 // Similar but safe cases.
73 EXPECT_TRUE(context_->IsAccessValid(CreateFileSystemURL(" ."))); 73 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL(" .")));
74 EXPECT_TRUE(context_->IsAccessValid(CreateFileSystemURL(". "))); 74 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL(". ")));
75 EXPECT_TRUE(context_->IsAccessValid(CreateFileSystemURL("b."))); 75 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL("b.")));
76 EXPECT_TRUE(context_->IsAccessValid(CreateFileSystemURL(".b"))); 76 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL(".b")));
77 77
78 // A path that looks like a drive letter. 78 // A path that looks like a drive letter.
79 EXPECT_TRUE(context_->IsAccessValid(CreateFileSystemURL("c:"))); 79 EXPECT_TRUE(delegate_->IsAccessValid(CreateFileSystemURL("c:")));
80 } 80 }
81 81
82 } // namespace fileapi 82 } // namespace fileapi
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698