Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 23163008: Update webrtc.DEPS gflags revision 45:84 (Closed)

Created:
7 years, 4 months ago by kjellander_chromium
Modified:
7 years, 4 months ago
CC:
chromium-reviews, hellner1
Visibility:
Public.

Description

Update webrtc.DEPS gflags revision 45:84 This is needed as gflags it was rolled (and renamed) in WebRTC https://code.google.com/p/webrtc/source/detail?r=4555 TEST=webrtc:2059 BUG=none

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 1 1 chunk +4 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
kjellander_chromium
This will be needed to get the Android build as described in https://code.google.com/p/webrtc/issues/detail?id=1882 to work ...
7 years, 4 months ago (2013-08-19 09:27:02 UTC) #1
Ami GONE FROM CHROMIUM
LGTM https://codereview.chromium.org/23163008/diff/4001/DEPS File DEPS (right): https://codereview.chromium.org/23163008/diff/4001/DEPS#newcode17 DEPS:17: "http://gflags.googlecode.com/svn/trunk/src@84", IWBN to comment in the main DEPS ...
7 years, 4 months ago (2013-08-19 23:22:44 UTC) #2
kjellander_chromium
On 2013/08/19 23:22:44, Ami Fischman wrote: > LGTM > > https://codereview.chromium.org/23163008/diff/4001/DEPS > File DEPS (right): ...
7 years, 4 months ago (2013-08-20 09:34:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/23163008/4001
7 years, 4 months ago (2013-08-20 09:34:47 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 09:34:57 UTC) #5
Message was sent while issue was closed.
Change committed as 218426

Powered by Google App Engine
This is Rietveld 408576698