Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 23163005: Add an exception and friendly presubmit error on invalid PNG file. (Closed)

Created:
7 years, 4 months ago by flackr
Modified:
7 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Add an exception and friendly presubmit error on invalid PNG file. BUG=272958 TEST=Corrupt a PNG file and run git cl presubmit. Error message identifies that the PNG file is corrupt. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217601

Patch Set 1 #

Patch Set 2 : Two spaces between top level blocks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M ui/resources/resource_check/resource_scale_factors.py View 1 5 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
flackr
Hi, please take a look. This makes the error when we have a PNG file ...
7 years, 4 months ago (2013-08-14 14:00:13 UTC) #1
oshima
lgtm
7 years, 4 months ago (2013-08-14 15:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23163005/4001
7 years, 4 months ago (2013-08-14 15:44:47 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 19:06:45 UTC) #4
Message was sent while issue was closed.
Change committed as 217601

Powered by Google App Engine
This is Rietveld 408576698