Changes the Omnibox input type to SEARCH.

Changes the text input type of Omnibox (Views) to TEXT_INPUT_TYPE_SEARCH.

If we specifies the text input type to TEXT_INPUT_TYPE_URL, MS-IME on Win8 metro thinks URL must be ASCII and always switches to Latin character mode (aka direct input mode) automatically, even if a user changed to non-Latin (e.g. Japanese) character mode last time.
This behavior is not good for those who use non-Latin characters in their daily life.

If we specifies the text input type to TEXT_INPUT_TYPE_SEARCH, MS-IME keeps the input mode specified last time.

The drawback of this CL is that MS-IME does not show '/' and '.com' keys on a software keyboard.  We think this change is worth making considering the number of users who use non-Latin characters and who use Latin characters on a software keyboard.

BUG=247994
TEST=Test manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223584

[Yuki, 2013-08-28 07:27:02]

Could you review this CL?

You can read the discussion how this issue should be fixed at
http://crbug.com/247994

[Peter Kasting, 2013-08-28 07:43:16]

Commented on bug

[Yuki, 2013-09-13 13:52:11]

Hi Peter,

According to your feedback, I've updated this CL so it sets
TEXT_INPUT_TYPE_SEARCH only to CJK + Thai users.

What do you think?

[Peter Kasting, 2013-09-13 17:16:36]

This seems like a reasonable bandaid.

https://codereview.chromium.org/23159008/diff/13001/chrome/browser/ui/views/o...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://codereview.chromium.org/23159008/diff/13001/chrome/browser/ui/views/o...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:102: //
ui::TEXT_INPUT_TYPE_URL for the rest who are likely non-IME users.
Nit: This comment is pretty good, here's my attempt at fixing some grammar
issues and clarifying:

We'd like to set the text input type to TEXT_INPUT_TYPE_URL, because this
triggers URL-specific layout in software keyboards, e.g. adding top-level "/"
and ".com" keys for English.  However, this also causes IMEs to default to Latin
character mode, which makes entering search queries difficult for IME users. 
Therefore, we try to guess whether an IME will be used based on the application
language, and set the input type accordingly.

https://codereview.chromium.org/23159008/diff/13001/chrome/browser/ui/views/o...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:109: // Suppose CJK + Thai
users are using an IME.
Nit: Suppose -> Assume

[Peter Kasting, 2013-09-13 17:16:54]

Forgot to say LGTM

[Yuki, 2013-09-17 08:33:39]

Thanks for the review.  Committing.

https://codereview.chromium.org/23159008/diff/13001/chrome/browser/ui/views/o...
File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right):

https://codereview.chromium.org/23159008/diff/13001/chrome/browser/ui/views/o...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:102: //
ui::TEXT_INPUT_TYPE_URL for the rest who are likely non-IME users.
On 2013/09/13 17:16:37, Peter Kasting wrote:
> Nit: This comment is pretty good, here's my attempt at fixing some grammar
> issues and clarifying:
> 
> We'd like to set the text input type to TEXT_INPUT_TYPE_URL, because this
> triggers URL-specific layout in software keyboards, e.g. adding top-level "/"
> and ".com" keys for English.  However, this also causes IMEs to default to
Latin
> character mode, which makes entering search queries difficult for IME users. 
> Therefore, we try to guess whether an IME will be used based on the
application
> language, and set the input type accordingly.

Done.

https://codereview.chromium.org/23159008/diff/13001/chrome/browser/ui/views/o...
chrome/browser/ui/views/omnibox/omnibox_view_views.cc:109: // Suppose CJK + Thai
users are using an IME.
On 2013/09/13 17:16:37, Peter Kasting wrote:
> Nit: Suppose -> Assume

Done.

[commit-bot: I haz the power, 2013-09-17 08:36:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/23159008/7001

[commit-bot: I haz the power, 2013-09-17 08:44:40]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-09-17 09:02:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/23159008/40001

[commit-bot: I haz the power, 2013-09-17 12:02:06]

Change committed as 223584