Implement ToValue() for SystemMetrics, SystemMemoryInfoKB, DiskInfo, and SwapInfo.

Implement ToValue() for SystemMetrics, SystemMemoryInfoKB, DiskInfo, and SwapInfo. These are used to serialize the data inside these structs.

BUG=236763
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221696

[nduca, 2013-08-14 18:08:57]

if a struct is declared on multiple platforsm, then my advice is to put the
function implementaiton in the common cc file, eg process_metrics.cc. Use ifdefs
to handle the platform specific fields.

https://codereview.chromium.org/23155002/diff/3001/base/process/process_metri...
File base/process/process_metrics_linux.cc (right):

https://codereview.chromium.org/23155002/diff/3001/base/process/process_metri...
base/process/process_metrics_linux.cc:517: Value* SystemMemoryInfoKB::AsValue()
const {
this hsould be in process_metrics.cc with #ifdefs for the things that are
common.

https://codereview.chromium.org/23155002/diff/3001/base/process/process_metri...
base/process/process_metrics_linux.cc:797: if (compr_data_size > 0) {
one line ifs dont get braces

[jwmak, 2013-08-14 18:39:27]

On 2013/08/14 18:08:57, nduca wrote:
> if a struct is declared on multiple platforsm, then my advice is to put the
> function implementaiton in the common cc file, eg process_metrics.cc. Use
ifdefs
> to handle the platform specific fields.
> 
>
https://codereview.chromium.org/23155002/diff/3001/base/process/process_metri...
> File base/process/process_metrics_linux.cc (right):
> 
>
https://codereview.chromium.org/23155002/diff/3001/base/process/process_metri...
> base/process/process_metrics_linux.cc:517: Value*
SystemMemoryInfoKB::AsValue()
> const {
> this hsould be in process_metrics.cc with #ifdefs for the things that are
> common.
> 
>
https://codereview.chromium.org/23155002/diff/3001/base/process/process_metri...
> base/process/process_metrics_linux.cc:797: if (compr_data_size > 0) {
> one line ifs dont get braces

Done.

[nduca, 2013-08-15 01:07:37]

lgtm

[darin (slow to review), 2013-08-31 03:45:12]

https://codereview.chromium.org/23155002/diff/40001/base/process/process_metr...
File base/process/process_metrics.h (right):

https://codereview.chromium.org/23155002/diff/40001/base/process/process_metr...
base/process/process_metrics.h:248: Value* AsValue() const;
nit: this should return scoped_ptr<Value>

nit: this seems like more of a heavy-weight conversion, so I'd probably go with
ToValue() instead. the "As" prefix works better when an object is a Foo and a
Bar, and you just want to get it *as* one of those.

https://codereview.chromium.org/23155002/diff/40001/base/process/process_metr...
base/process/process_metrics.h:289: Value* AsValue() const;
ditto, same nits.

[jwmak, 2013-09-04 18:49:18]

https://codereview.chromium.org/23155002/diff/40001/base/process/process_metr...
File base/process/process_metrics.h (right):

https://codereview.chromium.org/23155002/diff/40001/base/process/process_metr...
base/process/process_metrics.h:248: Value* AsValue() const;
On 2013/08/31 03:45:12, darin wrote:
> nit: this should return scoped_ptr<Value>
> 
> nit: this seems like more of a heavy-weight conversion, so I'd probably go
with
> ToValue() instead. the "As" prefix works better when an object is a Foo and a
> Bar, and you just want to get it *as* one of those.

Done.

https://codereview.chromium.org/23155002/diff/40001/base/process/process_metr...
base/process/process_metrics.h:289: Value* AsValue() const;
On 2013/08/31 03:45:12, darin wrote:
> ditto, same nits.

Done.

[darin (slow to review), 2013-09-05 07:32:10]

LGTM

https://codereview.chromium.org/23155002/diff/45001/base/process/process_metr...
File base/process/process_metrics.cc (right):

https://codereview.chromium.org/23155002/diff/45001/base/process/process_metr...
base/process/process_metrics.cc:35: res->Set("meminfo",
memory_info_.ToValue().release());
I see. DictionaryValue::Set should probably take scoped_ptr values, but that
certainly is outside the scope of this CL.

[commit-bot: I haz the power, 2013-09-05 16:17:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwmak@chromium.org/23155002/45001

[commit-bot: I haz the power, 2013-09-05 17:03:47]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-05 17:28:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwmak@chromium.org/23155002/67001

[commit-bot: I haz the power, 2013-09-06 04:56:33]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-09-06 12:05:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwmak@chromium.org/23155002/67001

[commit-bot: I haz the power, 2013-09-06 13:13:26]

Change committed as 221696