Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 23143004: dbus: Suppress NameHasNoOwner errors when connecting to signals (Closed)

Created:
7 years, 4 months ago by satorux1
Modified:
7 years, 4 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews
Visibility:
Public.

Description

dbus: Suppress NameHasNoOwner errors when connecting to signals The NameHasNoOwner errors are emitted as Chrome tries to get the identity of the service when connecting to signals for sender verification (crbug.com/140938), but the service may not yet be running, which is all right, hence the NameHasNoOwner errors here should be just supressed. BUG=273829 TEST=out/Debug/dbus_unittests --gtest_filter=SignalSenderVerificationTest.TestSignalAccepted; confirm that NameHasNoOwner is no longre emitted. Previously, an error message like below was emited: [12721:12722:0816/144031:3991948732792:ERROR:bus.cc(892)] Failed to get name owner. Got org.freedesktop.DBus.Error.NameHasNoOwner: Could not get owner of name 'org.chromium.TestService': no such name Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M dbus/object_proxy.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
7 years, 4 months ago (2013-08-16 06:03:26 UTC) #1
Seigo Nonaka
lgtm
7 years, 4 months ago (2013-08-16 07:05:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/23143004/1
7 years, 4 months ago (2013-08-16 07:05:54 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 09:16:43 UTC) #4
Message was sent while issue was closed.
Change committed as 217980

Powered by Google App Engine
This is Rietveld 408576698