Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 23140007: Support WebRTC in Android build toolchain (Closed)

Created:
7 years, 4 months ago by kjellander_chromium
Modified:
7 years, 4 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, hellner1
Visibility:
Public.

Description

Support WebRTC in Android build toolchain It turns out the changes in https://codereview.chromium.org/17466002/ was not enough. WebRTC needs two GYP_DEFINE variables to be passed to the runhooks step in order to generate the right GYP projects: include_tests=1 enable_tracing=1 We also need to use another build target than the default (All) to compile only our tests. This makes it possible to build the right APKs for the Android Builder in the client.webrtc waterfall in: https://codereview.chromium.org/17390019/ TEST=local builds BUG=webrtc:1882 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219016

Patch Set 1 : #

Patch Set 2 : Updated renamed test modules_integrationtests -> modules_tests #

Patch Set 3 : Added condition to avoid errors when doing a non-WebRTC android_gyp run. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M build/all_android.gyp View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 2 chunks +4 lines, -1 line 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_chromium
This now builds and runs the tests properly when I'm testing locally with a device. ...
7 years, 4 months ago (2013-08-21 09:49:41 UTC) #1
Isaac (away)
lgtm. I think this process barrier between bb_run_bot and bb_host_steps needs to get removed --it's ...
7 years, 4 months ago (2013-08-21 10:14:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/23140007/14001
7 years, 4 months ago (2013-08-22 09:13:38 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 14:22:27 UTC) #4
Message was sent while issue was closed.
Change committed as 219016

Powered by Google App Engine
This is Rietveld 408576698