Added of new UMA signals in order to be able to discover early if the "save password" feature gets …

chrome/browser/password_manager/password_manager_metrics_util_unittest.cc

Index: chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6d28cd992ea5f312136c536c799497090efb060c
--- /dev/null
+++ b/chrome/browser/password_manager/password_manager_metrics_util_unittest.cc
@@ -0,0 +1,65 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/password_manager/password_manager_metrics_util.h"
+
+#include <iterator>
+#include <map>
+
+#include "base/basictypes.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+bool IsMonitored(const char* url_host) {
+  return password_manager_metrics_util::MonitoredDomainGroupId(url_host) > 0;
+}
+
+}  // namespace
+
+TEST(PasswordManagerTest, MonitoredDomainGroupAssigmentTest) {

[vabr (Chromium), 2013/09/16 12:08:13]

Please change the test name to PasswordManagerMetricsUtilTest. Having the
existing test class (PasswordManagerTest) makes the unittests fail, because it
is used elsewhere with the slightly different TEST_F (fixture) macro.

+  const char* const kMonitoredWebsites[] = {
+      "https://www.google.com",
+      "https://www.yahoo.com",
+      "https://www.baidu.com",
+      "https://www.wikipedia.org",
+      "https://www.linkedin.com",
+      "https://www.twitter.com",
+      "https://www.live.com",
+      "https://www.amazon.com",
+      "https://www.ebay.com",
+      "https://www.tumblr.com",
+  };
+  const size_t kMonitoredWebsitesLength = arraysize(kMonitoredWebsites);
+
+  // The |groups| map contains the group id and the number of times
+  // it get assigned.
+  std::map<size_t, size_t> groups;
+
+  // Provide all possible values of the group id parameter for each monitored
+  // website.
+  for (size_t i = 0; i < kMonitoredWebsitesLength; ++i) {
+    for (size_t j = 0; j < password_manager_metrics_util::kGroupsPerDomain;
+         ++j) {
+      password_manager_metrics_util::SetRandomIndexForTesting(j);
+      ++groups[password_manager_metrics_util::MonitoredDomainGroupId(
+            kMonitoredWebsites[i])];
+    }
+  }
+
+  // Check if all groups get assigned the same number of times.
+  size_t number_of_assigment = groups.begin()->second;
+  for (std::map<size_t, size_t>::iterator it = groups.begin();
+       it != groups.end(); ++it) {
+    EXPECT_EQ(it->second, number_of_assigment) << " group id = " << it->first;
+  }
+}
+
+TEST(PasswordManagerTest, MonitoredDomainGroupTest) {
+  EXPECT_TRUE(IsMonitored("https://www.linkedin.com"));
+  EXPECT_TRUE(IsMonitored("https://www.amazon.com"));
+  EXPECT_FALSE(IsMonitored("https://www.facebook.com"));
+  EXPECT_TRUE(IsMonitored("http://wikipedia.org"));
+  EXPECT_FALSE(IsMonitored("http://thisisnotwikipedia.org"));
+}