Issue 23137015: Move async_socket_io_handler.* from media/ to base/

Issue 23137015: Move async_socket_io_handler.* from media/ to base/ (Closed)

Created:
7 years, 4 months ago by qsr

Modified:
7 years, 3 months ago

Reviewers:
tommi (sloooow) - chröme, darin (slow to review), qsr (NOT THE RIGHT qsr), DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move async_socket_io_handler.* from media/ to base/ TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219000

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -468 lines)			Patch
A +	base/async_socket_io_handler.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
A +	base/async_socket_io_handler_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	base/async_socket_io_handler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	base/async_socket_io_handler_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gyp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
D	media/audio/async_socket_io_handler.h	View	1 chunk	+0 lines, -113 lines	0 comments	Download
D	media/audio/async_socket_io_handler_posix.cc	View	1 chunk	+0 lines, -98 lines	0 comments	Download
D	media/audio/async_socket_io_handler_unittest.cc	View	1 chunk	+0 lines, -168 lines	0 comments	Download
D	media/audio/async_socket_io_handler_win.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	media/media.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

qsr

On 2013/08/22 09:55:40, tommi wrote: > lgtm TBR darin for owner approval.

7 years, 4 months ago (2013-08-22 09:57:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/23137015/1

7 years, 4 months ago (2013-08-22 09:57:52 UTC) #5

DaleCurtis

Are you actually using this code somewhere? Or planning to? I was in the middle ...

7 years, 3 months ago (2013-08-27 00:09:52 UTC) #7

qsr (NOT THE RIGHT qsr)

7 years, 3 months ago (2013-08-27 08:00:24 UTC) #8

 I'm planning to use it. Please don't delete :)

On Tue, Aug 27, 2013 at 2:09 AM, <dalecurtis@chromium.org> wrote:

> Are you actually using this code somewhere?  Or planning to?  I was in the
> middle of deleting it :)
>
>
https://chromiumcodereview.**appspot.com/23137015/<https://chromiumcodereview...
>

-- 
        Benjamin

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages