Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 23137012: Added LayoutTest for use-after-free regression with bidi isolates. (Closed)

Created:
7 years, 4 months ago by jww
Modified:
7 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw_travelin_and_unemployed, igoroliveira
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Added LayoutTest for use-after-free regression with bidi isolates. BUG=265838 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156580

Patch Set 1 #

Patch Set 2 : Modified test to output PASS if does not crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A LayoutTests/fast/text/international/unicode-bidi-isolate-nested-with-removes.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/unicode-bidi-isolate-nested-with-removes-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jww
This is the use-after-free minified repro case for https://crbug.com/265838. It was fixed by Igor's fix ...
7 years, 4 months ago (2013-08-22 01:11:55 UTC) #1
eseidel
I would make this testRunner.dumpAsText() and add the text somewhere that says "PASS if did ...
7 years, 4 months ago (2013-08-22 02:42:05 UTC) #2
eseidel
With it dumpAsText lgtm.
7 years, 4 months ago (2013-08-22 02:42:20 UTC) #3
jww
On 2013/08/22 02:42:20, eseidel wrote: > With it dumpAsText lgtm. Done.
7 years, 4 months ago (2013-08-22 19:21:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/23137012/6001
7 years, 4 months ago (2013-08-22 19:22:24 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 21:26:00 UTC) #6
Message was sent while issue was closed.
Change committed as 156580

Powered by Google App Engine
This is Rietveld 408576698