Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 23135009: Improve IDB module's SecurityError messages. (Closed)

Created:
7 years, 4 months ago by Mike West
Modified:
7 years, 3 months ago
CC:
blink-reviews, alecflett, dglazkov+blink, eae+blinkwatch, dgrogan
Visibility:
Public.

Description

Improve IDB module's SecurityError messages. BUG=152212 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157369

Patch Set 1 #

Patch Set 2 : build #

Patch Set 3 : test #

Total comments: 2

Patch Set 4 : rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Only IDB. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M LayoutTests/fast/frames/resources/sandboxed-iframe-storage-disallowed.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mike West
Hi Jochen, WDYT? Note that I've poked at the notification tests, but they don't work. ...
7 years, 4 months ago (2013-08-20 08:37:23 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/23135009/diff/7001/Source/testing/runner/TestRunner.cpp File Source/testing/runner/TestRunner.cpp (right): https://codereview.chromium.org/23135009/diff/7001/Source/testing/runner/TestRunner.cpp#newcode1863 Source/testing/runner/TestRunner.cpp:1863: m_notificationPresenter->removeAllWebNotificationPermissions(); why not do this in TestRunner::reset automatically?
7 years, 4 months ago (2013-08-21 08:48:14 UTC) #2
jsbell
IDB change lgtm https://codereview.chromium.org/23135009/diff/7001/Source/modules/indexeddb/IDBFactory.cpp File Source/modules/indexeddb/IDBFactory.cpp (right): https://codereview.chromium.org/23135009/diff/7001/Source/modules/indexeddb/IDBFactory.cpp#newcode85 Source/modules/indexeddb/IDBFactory.cpp:85: es.throwSecurityError(ExceptionMessages::failedToExecute("getDatabaseNames", "IDBFactory", "access to the Indexed ...
7 years, 4 months ago (2013-08-21 20:18:58 UTC) #3
jsbell
FYI, the lack of an IDB test for this is captured in http://crbug.com/113738 - may ...
7 years, 4 months ago (2013-08-21 20:20:36 UTC) #4
Mike West
I've dropped the TestRunner bits. They didn't work anyway.
7 years, 3 months ago (2013-09-06 11:58:05 UTC) #5
Mike West
On 2013/09/06 11:58:05, Mike West wrote: > I've dropped the TestRunner bits. They didn't work ...
7 years, 3 months ago (2013-09-06 12:07:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23135009/26001
7 years, 3 months ago (2013-09-06 12:26:56 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 3 months ago (2013-09-06 14:28:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/23135009/26001
7 years, 3 months ago (2013-09-06 14:45:31 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 14:45:48 UTC) #10
Message was sent while issue was closed.
Change committed as 157369

Powered by Google App Engine
This is Rietveld 408576698