Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: content/renderer/render_view_impl.cc

Issue 23129015: Initialize RenderWidget(Host)(View)s with correct visibility state (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_view_impl_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index d64150c58ab800f2acbe30bff3c22a6fcf0af657..0c51106516f15f54f03edeefff8393a620ece91f 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -780,7 +780,8 @@ WebDragData DropDataToWebDragData(const DropData& drop_data) {
RenderViewImpl::RenderViewImpl(RenderViewImplParams* params)
: RenderWidget(WebKit::WebPopupTypeNone,
params->screen_info,
- params->swapped_out),
+ params->swapped_out,
+ params->hidden),
webkit_preferences_(params->webkit_prefs),
send_content_state_immediately_(false),
enabled_bindings_(0),
@@ -900,6 +901,8 @@ void RenderViewImpl::Initialize(RenderViewImplParams* params) {
// Take a reference on behalf of the RenderThread. This will be balanced
// when we receive ViewMsg_ClosePage.
AddRef();
+ if (is_hidden_)
+ RenderThread::Get()->WidgetHidden();
// If this is a popup, we must wait for the CreatingNew_ACK message before
// completing initialization. Otherwise, we can finish it now.
@@ -1073,6 +1076,7 @@ RenderViewImpl* RenderViewImpl::Create(
const string16& frame_name,
bool is_renderer_created,
bool swapped_out,
+ bool hidden,
int32 next_page_id,
const WebKit::WebScreenInfo& screen_info,
AccessibilityMode accessibility_mode,
@@ -1090,6 +1094,7 @@ RenderViewImpl* RenderViewImpl::Create(
frame_name,
is_renderer_created,
swapped_out,
+ hidden,
next_page_id,
screen_info,
accessibility_mode,
@@ -2342,9 +2347,10 @@ WebView* RenderViewImpl::createView(
surface_id,
cloned_session_storage_namespace_id,
string16(), // WebCore will take care of setting the correct name.
- true,
- false,
- 1,
+ true, // is_renderer_created
+ false, // swapped_out
+ false, // hidden
+ 1, // next_page_id
screen_info_,
accessibility_mode_,
allow_partial_swap_);
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_view_impl_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698