Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 23129015: Initialize RenderWidget(Host)(View)s with correct visibility state (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_process_visibility_manager.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index f15738dd00aa0f4b4096928efe16ee39d3030c9a..d27a20d51858407d71be04e2c3880d551168aca0 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -77,7 +77,6 @@
#include "content/renderer/memory_benchmarking_extension.h"
#include "content/renderer/p2p/socket_dispatcher.h"
#include "content/renderer/render_process_impl.h"
-#include "content/renderer/render_process_visibility_manager.h"
#include "content/renderer/render_view_impl.h"
#include "content/renderer/renderer_webkitplatformsupport_impl.h"
#include "content/renderer/skia_benchmarking_extension.h"
@@ -622,29 +621,25 @@ void RenderThreadImpl::SetResourceDispatcherDelegate(
}
void RenderThreadImpl::WidgetHidden() {
- DCHECK(hidden_widget_count_ < widget_count_);
+ DCHECK_LT(hidden_widget_count_, widget_count_);
hidden_widget_count_++;
- RenderProcessVisibilityManager* manager =
- RenderProcessVisibilityManager::GetInstance();
- manager->WidgetVisibilityChanged(false);
-
- if (!GetContentClient()->renderer()->RunIdleHandlerWhenWidgetsHidden()) {
- return;
+ if (widget_count_ && hidden_widget_count_ == widget_count_) {
+#if !defined(SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE)
+ // TODO(vollick): Remove this this heavy-handed approach once we're polling
+ // the real system memory pressure.
+ base::MemoryPressureListener::NotifyMemoryPressure(
+ base::MemoryPressureListener::MEMORY_PRESSURE_MODERATE);
+#endif
+ if (GetContentClient()->renderer()->RunIdleHandlerWhenWidgetsHidden())
+ ScheduleIdleHandler(kInitialIdleHandlerDelayMs);
}
-
- if (widget_count_ && hidden_widget_count_ == widget_count_)
- ScheduleIdleHandler(kInitialIdleHandlerDelayMs);
}
void RenderThreadImpl::WidgetRestored() {
DCHECK_GT(hidden_widget_count_, 0);
hidden_widget_count_--;
- RenderProcessVisibilityManager* manager =
- RenderProcessVisibilityManager::GetInstance();
- manager->WidgetVisibilityChanged(true);
-
if (!GetContentClient()->renderer()->RunIdleHandlerWhenWidgetsHidden()) {
return;
}
@@ -1146,6 +1141,7 @@ void RenderThreadImpl::OnCreateNewView(const ViewMsg_New_Params& params) {
params.frame_name,
false,
params.swapped_out,
+ params.hidden,
params.next_page_id,
params.screen_info,
params.accessibility_mode,
« no previous file with comments | « content/renderer/render_process_visibility_manager.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698