Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 23129011: WebCrypto: Add length parameter for HMAC key generation. (Closed)

Created:
7 years, 4 months ago by eroman
Modified:
7 years, 4 months ago
CC:
blink-reviews, Nils Barth (inactive), jamesr, kojih, jsbell+bindings_chromium.org, eae+blinkwatch, tommyw+watchlist_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, jeez
Visibility:
Public.

Description

WebCrypto: Add length parameter for HMAC key generation. This corresponds with the spec change that adds HmacKeyParams: https://dvcs.w3.org/hg/webcrypto-api/rev/a7155b0c720d BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156343

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase onto head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -15 lines) Patch
M LayoutTests/crypto/generateKey.html View 1 chunk +29 lines, -2 lines 0 comments Download
M LayoutTests/crypto/generateKey-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8AlgorithmCustom.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/crypto/Algorithm.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
A + Source/modules/crypto/HmacKeyParams.h View 1 chunk +7 lines, -5 lines 0 comments Download
A + Source/modules/crypto/HmacKeyParams.cpp View 1 chunk +11 lines, -5 lines 0 comments Download
A + Source/modules/crypto/HmacKeyParams.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 3 chunks +21 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 1 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebCryptoAlgorithm.h View 3 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithmParams.h View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
7 years, 4 months ago (2013-08-17 04:37:06 UTC) #1
do-not-use
https://codereview.chromium.org/23129011/diff/1/Source/modules/crypto/HmacKeyParams.idl File Source/modules/crypto/HmacKeyParams.idl (right): https://codereview.chromium.org/23129011/diff/1/Source/modules/crypto/HmacKeyParams.idl#newcode33 Source/modules/crypto/HmacKeyParams.idl:33: ] interface HmacKeyParams : Algorithm { I know this ...
7 years, 4 months ago (2013-08-18 06:50:04 UTC) #2
eroman
https://codereview.chromium.org/23129011/diff/1/Source/modules/crypto/HmacKeyParams.idl File Source/modules/crypto/HmacKeyParams.idl (right): https://codereview.chromium.org/23129011/diff/1/Source/modules/crypto/HmacKeyParams.idl#newcode33 Source/modules/crypto/HmacKeyParams.idl:33: ] interface HmacKeyParams : Algorithm { On 2013/08/18 06:50:04, ...
7 years, 4 months ago (2013-08-18 07:46:38 UTC) #3
do-not-use
On 2013/08/18 07:46:38, eroman wrote: > https://codereview.chromium.org/23129011/diff/1/Source/modules/crypto/HmacKeyParams.idl > File Source/modules/crypto/HmacKeyParams.idl (right): > > https://codereview.chromium.org/23129011/diff/1/Source/modules/crypto/HmacKeyParams.idl#newcode33 > ...
7 years, 4 months ago (2013-08-18 11:22:03 UTC) #4
do-not-use
On 2013/08/18 11:22:03, Christophe Dumez wrote: > On 2013/08/18 07:46:38, eroman wrote: > > > ...
7 years, 4 months ago (2013-08-18 11:23:52 UTC) #5
abarth-chromium
lgtm
7 years, 4 months ago (2013-08-19 19:20:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23129011/12001
7 years, 4 months ago (2013-08-19 22:14:38 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 23:59:08 UTC) #8
Message was sent while issue was closed.
Change committed as 156343

Powered by Google App Engine
This is Rietveld 408576698