App install alert button fixes

chrome/android/java/res/layout/app_banner_view.xml

Index: chrome/android/java/res/layout/app_banner_view.xml
diff --git a/chrome/android/java/res/layout/app_banner_view.xml b/chrome/android/java/res/layout/app_banner_view.xml
index 267fd2367dda32959028907b722f8323c24fa4cd..cb5a4b9aa0ea22926cde9bcfc92517ac9ba938f8 100644
--- a/chrome/android/java/res/layout/app_banner_view.xml
+++ b/chrome/android/java/res/layout/app_banner_view.xml
@@ -35,18 +35,18 @@
     <!-- Button that triggers installation and opening of the app. -->
     <Button
             android:id="@+id/app_install_button"
-            android:background="@drawable/app_banner_button_install"
+            style="@style/AppBannerButton"
+            android:textColor="@color/app_banner_install_button_fg"
+            android:ellipsize="end"

[newt (away), 2014/04/09 19:01:05]

Once the user clicks on the button, you could consider changing ellipsize="end"
to marqueeing once. At that point, we know the user is interested in the app
banner. I agree that initially we should avoid distracting the user with a
marquee.

[gone, 2014/04/09 20:28:44]

Marqueeing just looks really distracting.

+            android:singleLine="true"
             android:minHeight="@dimen/app_banner_button_height"
-            android:lines="1"
-            android:textAppearance="@style/AppBannerButton"
             android:paddingStart="@dimen/app_banner_button_padding_sides"
             android:paddingEnd="@dimen/app_banner_button_padding_sides"
             android:paddingTop="@dimen/app_banner_button_padding_above_below"
             android:paddingBottom="@dimen/app_banner_button_padding_above_below"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginTop="@dimen/app_banner_button_margin_top"
-            android:layout_marginStart="@dimen/app_banner_button_margin_start" />
+            android:layout_marginTop="@dimen/app_banner_button_margin_top" />
 
     <!-- Logo for the store. -->
     <ImageView
@@ -56,7 +56,8 @@
             android:layout_width="wrap_content"
             android:layout_height="@dimen/app_banner_logo_height"
             android:layout_marginTop="@dimen/app_banner_logo_margin_top"
-            android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom" />
+            android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom"
+            android:layout_marginEnd="@dimen/app_banner_logo_margin_end"/>
 
     <!-- View showing how well the app is rated. -->
     <org.chromium.chrome.browser.banners.RatingView