Switch Google Now Background Toggle to use Experiment Variations

Switch Google Now Background Toggle to use Experiment Variations

Instead of checking the string returned from GetFieldTrial, a variation
of params.enableBackground will contain if the background permission
should be requested or removed.

BUG=164227
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217449

[vadimt, 2013-08-13 21:05:15]

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:874: (response &&
(response.enableBackground != 'false'));
!response || response.enableBackground != 'false'.

We want background to be the default.

[robliao, 2013-08-13 21:09:15]

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:874: (response &&
(response.enableBackground != 'false'));
That's a bit more permissive than I was expecting.

Which experiments will not include a variation param but still enable Google
Now?

If there's no response, we should treat it as an error, and not enable
background.

On 2013/08/13 21:05:15, vadimt wrote:
> !response || response.enableBackground != 'false'.
> 
> We want background to be the default.

[vadimt, 2013-08-13 21:17:10]

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:874: (response &&
(response.enableBackground != 'false'));
On 2013/08/13 21:09:15, Robert Liao wrote:
> That's a bit more permissive than I was expecting.
> 
> Which experiments will not include a variation param but still enable Google
> Now?
> 
> If there's no response, we should treat it as an error, and not enable
> background.
> 
> On 2013/08/13 21:05:15, vadimt wrote:
> > !response || response.enableBackground != 'false'.
> > 
> > We want background to be the default.
> 

Background is a "normal" behavior, and the absence of thereof is an anomaly that
we introduce to compare it with the normal behavior. If in doubt, it's better to
choose the normal behavior.

This is also a step towards being able to delete the experiment after it's not
needed anymore without having to wait till new Chrome build.

[robliao, 2013-08-13 21:30:32]

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/23127002/diff/1/chrome/browser/resources/goog...
chrome/browser/resources/google_now/background.js:874: (response &&
(response.enableBackground != 'false'));
On 2013/08/13 21:17:10, vadimt wrote:
> On 2013/08/13 21:09:15, Robert Liao wrote:
> > That's a bit more permissive than I was expecting.
> > 
> > Which experiments will not include a variation param but still enable Google
> > Now?
> > 
> > If there's no response, we should treat it as an error, and not enable
> > background.
> > 
> > On 2013/08/13 21:05:15, vadimt wrote:
> > > !response || response.enableBackground != 'false'.
> > > 
> > > We want background to be the default.
> > 
> 
> Background is a "normal" behavior, and the absence of thereof is an anomaly
that
> we introduce to compare it with the normal behavior. If in doubt, it's better
to
> choose the normal behavior.
> 
> This is also a step towards being able to delete the experiment after it's not
> needed anymore without having to wait till new Chrome build.

Done.

[vadimt, 2013-08-13 21:38:04]

lgtm

[robliao, 2013-08-13 21:38:41]

xiyuan: Please provide owner approval for this CL.

Thanks!

[xiyuan, 2013-08-13 21:41:56]

lgtm

[commit-bot: I haz the power, 2013-08-13 21:50:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/23127002/1003

[commit-bot: I haz the power, 2013-08-14 02:26:37]

Change committed as 217449