Issue 23122003: Fix crash on signing out with exit warning bubble open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23122003: Fix crash on signing out with exit warning bubble open. (Closed)

Created:
7 years, 4 months ago by xiyuan

Modified:
7 years, 4 months ago

Reviewers:
James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash on signing out with exit warning bubble open. Make ExitWarningHandler really own its bubble widget so that the widget will not be released before destructing ExitWarningHandler, which could happen when shutting down ash while the bubble is visible. BUG=272368 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217429

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -16 lines)			Patch
M	ash/accelerators/accelerator_controller_unittest.cc	View	6 chunks	+22 lines, -8 lines	0 comments	Download
M	ash/accelerators/exit_warning_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/accelerators/exit_warning_handler.cc	View	4 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/23122003/1

7 years, 4 months ago (2013-08-13 21:07:28 UTC) #3

Message was sent while issue was closed.

Change committed as 217429

Expand Messages | Collapse Messages