Add correctness test to bbh_shootout.

Add correctness test to bbh_shootout.

Committed: http://code.google.com/p/skia/source/detail?r=10809

[sglez, 2013-08-14 16:22:42]

Add a test to bbh_shootout that compares generated bitmaps.

[caryclark, 2013-08-14 17:36:10]

https://codereview.chromium.org/23121002/diff/10001/tools/bbh_shootout.cpp
File tools/bbh_shootout.cpp (right):

https://codereview.chromium.org/23121002/diff/10001/tools/bbh_shootout.cpp#ne...
tools/bbh_shootout.cpp:181: static bool compare_picture(const SkString& path,
SkPicture& pic, const SkBitmap* inBitmap) {
passing const inBitmap& , SkPicture* is more consistent with Skia and the rest
of your code.

https://codereview.chromium.org/23121002/diff/10001/tools/bbh_shootout.cpp#ne...
tools/bbh_shootout.cpp:236: if (i == 0 &&  kRTree_BenchmarkType == benchmarkType
&&  isPlayback) {
search for two spaces and replace them with one where appropriate

https://codereview.chromium.org/23121002/diff/10001/tools/bbh_shootout.cpp#ne...
tools/bbh_shootout.cpp:250: if(isPlayback && !result) {
space after 'if'

https://codereview.chromium.org/23121002/diff/10001/tools/bbh_shootout.cpp#ne...
tools/bbh_shootout.cpp:420: avgRecord, avgRecordRTree);
break this into two SkDebugf statements

[sglez, 2013-08-14 18:10:25]

Code review fixes

[sglez, 2013-08-15 13:52:40]

On 2013/08/14 18:10:25, sglez wrote:
> Code review fixes

Friendly-ish ping. (I have a loaded nerf gun with good range)

[caryclark, 2013-08-15 14:32:46]

https://codereview.chromium.org/23121002/diff/14001/tools/bbh_shootout.cpp
File tools/bbh_shootout.cpp (right):

https://codereview.chromium.org/23121002/diff/14001/tools/bbh_shootout.cpp#ne...
tools/bbh_shootout.cpp:181: static bool compare_picture(const SkString& path,
SkPicture& pic, const SkBitmap& inBitmap) {
Sorry I wasn't clear about this last time. If pic is modifiable, make it
SkPicture* , and put the parameter last.

[sglez, 2013-08-15 14:55:15]

https://codereview.chromium.org/23121002/diff/14001/tools/bbh_shootout.cpp
File tools/bbh_shootout.cpp (right):

https://codereview.chromium.org/23121002/diff/14001/tools/bbh_shootout.cpp#ne...
tools/bbh_shootout.cpp:181: static bool compare_picture(const SkString& path,
SkPicture& pic, const SkBitmap& inBitmap) {
On 2013/08/15 14:32:46, caryclark wrote:
> Sorry I wasn't clear about this last time. If pic is modifiable, make it
> SkPicture* , and put the parameter last.

Oops... I should also have the comment more carefully

[sglez, 2013-08-19 17:37:18]

Friendly ping =)

[caryclark, 2013-08-19 17:42:00]

lgtm

[commit-bot: I haz the power, 2013-08-19 18:19:11]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/sglez@google.com/23121002/19001

[commit-bot: I haz the power, 2013-08-20 12:23:22]

Change committed as 10809