|
chromeos: Laser tool blocks events from propagating.
After discussion concluded the best way was to delegate the laser pointer out of ash/common. Moved all the laser related files into ash/laser.
LaserPointerController.* replaces LaserPointerMode.* and it inherits from EventHandler to grab the events and propagate them to LaserPointerView/LaserPointerPoints, which remain the same. LaserPointerMode just inherits common palette tool and calls the delegate.
BUG= 644804
TEST=ash_unittests --gtest_filter="LaserPointer*"
https://screenshot.googleplex.com/BtwX1GTCpcW
Committed: https://crrev.com/203ae0296e08db2452a4558d3e84dcf713f6badf
Cr-Commit-Position: refs/heads/master@{#419400}
Total comments: 28
Total comments: 61
Total comments: 23
Total comments: 39
Total comments: 23
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+501 lines, -916 lines) |
Patch |
|
M |
ash/BUILD.gn
|
View
|
1
2
3
4
|
8 chunks |
+23 lines, -14 lines |
0 comments
|
Download
|
|
M |
ash/aura/wm_shell_aura.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
ash/aura/wm_shell_aura.cc
|
View
|
1
2
3
4
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
ash/common/palette_delegate.h
|
View
|
1
2
3
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/palette_tool.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/tools/laser_pointer_mode.h
|
View
|
|
3 chunks |
+2 lines, -29 lines |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/tools/laser_pointer_mode.cc
|
View
|
1
2
3
|
3 chunks |
+3 lines, -65 lines |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.h
|
View
|
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.cc
|
View
|
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
|
D |
ash/common/system/chromeos/palette/tools/laser_pointer_points.h
|
View
|
|
1 chunk |
+0 lines, -64 lines |
0 comments
|
Download
|
|
D |
ash/common/system/chromeos/palette/tools/laser_pointer_points.cc
|
View
|
|
1 chunk |
+0 lines, -74 lines |
0 comments
|
Download
|
|
D |
ash/common/system/chromeos/palette/tools/laser_pointer_points_test_api.h
|
View
|
|
1 chunk |
+0 lines, -36 lines |
0 comments
|
Download
|
|
D |
ash/common/system/chromeos/palette/tools/laser_pointer_points_test_api.cc
|
View
|
|
1 chunk |
+0 lines, -31 lines |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/tools/laser_pointer_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -192 lines |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/tools/laser_pointer_view.h
|
View
|
|
1 chunk |
+0 lines, -49 lines |
0 comments
|
Download
|
|
M |
ash/common/system/chromeos/palette/tools/laser_pointer_view.cc
|
View
|
|
1 chunk |
+0 lines, -139 lines |
0 comments
|
Download
|
|
M |
ash/common/test/test_palette_delegate.h
|
View
|
1
2
3
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
ash/common/test/test_palette_delegate.cc
|
View
|
1
2
3
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
ash/common/wm_shell.h
|
View
|
1
2
3
4
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
A |
ash/laser/laser_pointer_controller.h
|
View
|
1
2
3
4
5
6
|
1 chunk |
+76 lines, -0 lines |
0 comments
|
Download
|
|
A |
ash/laser/laser_pointer_controller.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+140 lines, -0 lines |
0 comments
|
Download
|
|
A |
ash/laser/laser_pointer_controller_test_api.h
|
View
|
1
2
3
4
5
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
A |
ash/laser/laser_pointer_controller_test_api.cc
|
View
|
1
2
3
4
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
A + |
ash/laser/laser_pointer_controller_unittest.cc
|
View
|
1
2
3
4
5
6
7
|
4 chunks |
+79 lines, -65 lines |
0 comments
|
Download
|
|
A + |
ash/laser/laser_pointer_points.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
A + |
ash/laser/laser_pointer_points.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A + |
ash/laser/laser_pointer_points_test_api.h
|
View
|
1
2
3
4
5
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
A + |
ash/laser/laser_pointer_points_test_api.cc
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
A + |
ash/laser/laser_pointer_view.h
|
View
|
1
2
3
4
5
6
|
3 chunks |
+14 lines, -6 lines |
0 comments
|
Download
|
|
A + |
ash/laser/laser_pointer_view.cc
|
View
|
1
2
3
4
5
6
|
7 chunks |
+40 lines, -12 lines |
0 comments
|
Download
|
|
M |
ash/magnifier/partial_magnification_controller.cc
|
View
|
1
2
3
4
|
5 chunks |
+5 lines, -16 lines |
0 comments
|
Download
|
|
M |
ash/mus/bridge/wm_shell_mus.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
ash/mus/bridge/wm_shell_mus.cc
|
View
|
1
2
3
4
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
ash/shell.h
|
View
|
1
2
3
4
5
|
5 chunks |
+11 lines, -6 lines |
0 comments
|
Download
|
|
M |
ash/shell.cc
|
View
|
1
2
3
4
5
6
|
4 chunks |
+8 lines, -3 lines |
0 comments
|
Download
|
|
M |
ash/shell/shell_delegate_impl.cc
|
View
|
1
2
3
4
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/ash/palette_delegate_chromeos.h
|
View
|
1
2
3
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/ash/palette_delegate_chromeos.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
Total messages: 87 (57 generated)
|