Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 23112031: Update pdf.gypi to actually work with Chromium (Closed)

Created:
7 years, 3 months ago by robertphillips
Modified:
7 years, 3 months ago
Reviewers:
edisonn, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Recent PDF changes have broken the Chromium Canary making it an excellent time to start using our pdf.gypi in Chromium's skia_library.gypi file. This slight modification is required since Chrome doesn't build the SkDocument_PDF.cpp file.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp/pdf.gyp View 1 chunk +2 lines, -0 lines 2 comments Download
M gyp/pdf.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
7 years, 3 months ago (2013-08-23 20:00:53 UTC) #1
djsollen
https://codereview.chromium.org/23112031/diff/1/gyp/pdf.gyp File gyp/pdf.gyp (right): https://codereview.chromium.org/23112031/diff/1/gyp/pdf.gyp#newcode23 gyp/pdf.gyp:23: '../src/doc/SkDocument_PDF.cpp', # Chromium does use this file what will ...
7 years, 3 months ago (2013-08-23 20:49:31 UTC) #2
robertphillips
https://codereview.chromium.org/23112031/diff/1/gyp/pdf.gyp File gyp/pdf.gyp (right): https://codereview.chromium.org/23112031/diff/1/gyp/pdf.gyp#newcode23 gyp/pdf.gyp:23: '../src/doc/SkDocument_PDF.cpp', # Chromium does use this file I don't ...
7 years, 3 months ago (2013-08-25 12:04:20 UTC) #3
djsollen
On 2013/08/25 12:04:20, robertphillips wrote: > https://codereview.chromium.org/23112031/diff/1/gyp/pdf.gyp > File gyp/pdf.gyp (right): > > https://codereview.chromium.org/23112031/diff/1/gyp/pdf.gyp#newcode23 > ...
7 years, 3 months ago (2013-08-26 11:19:30 UTC) #4
djsollen
So the only files to go into the *.gypi are the ones that chromium needs? ...
7 years, 3 months ago (2013-08-26 11:26:05 UTC) #5
robertphillips
I'm not sure files in doc belong in the pdf.gypi. Although we blend other gypi ...
7 years, 3 months ago (2013-08-26 12:52:41 UTC) #6
djsollen
lgtm and we can do the gypi refactoring later
7 years, 3 months ago (2013-08-26 13:04:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/23112031/1
7 years, 3 months ago (2013-08-26 13:15:37 UTC) #8
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildMost http://173.255.115.253:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=479
7 years, 3 months ago (2013-08-26 13:37:56 UTC) #9
robertphillips
7 years, 3 months ago (2013-08-26 13:47:37 UTC) #10
Message was sent while issue was closed.
committed as r10916

Powered by Google App Engine
This is Rietveld 408576698