Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 23112019: If an element has unicode-bidi: plaintext and no strong directional characters. By default it shoul… (Closed)

Created:
7 years, 4 months ago by igoroliveira
Modified:
7 years, 4 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, tkent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

If an element has unicode-bidi: plaintext and no strong directional characters. By default it should be LTR. BUG=277687 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156664

Patch Set 1 #

Total comments: 1

Patch Set 2 : Proposed patch v2 #

Total comments: 1

Patch Set 3 : Proposed patch v3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -18 lines) Patch
A LayoutTests/fast/text/international/dir-auto-in-textarea-neutral.html View 1 chunk +60 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/dir-auto-in-textarea-neutral-expected.html View 1 chunk +60 lines, -0 lines 0 comments Download
M Source/core/css/html.css View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 2 2 chunks +5 lines, -4 lines 1 comment Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 5 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
igoroliveira
7 years, 4 months ago (2013-08-22 17:56:16 UTC) #1
eseidel
lgtm This looks great. This is certainly putting isolate/plaintext code more in the critical path. ...
7 years, 4 months ago (2013-08-22 20:02:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23112019/1
7 years, 4 months ago (2013-08-22 20:02:45 UTC) #3
eseidel
https://codereview.chromium.org/23112019/diff/1/Source/core/html/HTMLElement.cpp File Source/core/html/HTMLElement.cpp (left): https://codereview.chromium.org/23112019/diff/1/Source/core/html/HTMLElement.cpp#oldcode849 Source/core/html/HTMLElement.cpp:849: if (isHTMLTextFormControlElement(this)) { There are other form controls other ...
7 years, 4 months ago (2013-08-22 20:03:07 UTC) #4
igoroliveira
On 2013/08/22 20:03:07, eseidel wrote: > https://codereview.chromium.org/23112019/diff/1/Source/core/html/HTMLElement.cpp > File Source/core/html/HTMLElement.cpp (left): > > https://codereview.chromium.org/23112019/diff/1/Source/core/html/HTMLElement.cpp#oldcode849 > ...
7 years, 4 months ago (2013-08-22 21:23:28 UTC) #5
igoroliveira
On 2013/08/22 21:23:28, Igor Oliveira wrote: > On 2013/08/22 20:03:07, eseidel wrote: > > > ...
7 years, 4 months ago (2013-08-22 21:33:17 UTC) #6
igoroliveira
Patch updated fixing input form regression.
7 years, 4 months ago (2013-08-22 22:01:31 UTC) #7
eseidel
https://codereview.chromium.org/23112019/diff/10001/Source/core/html/HTMLElement.cpp File Source/core/html/HTMLElement.cpp (right): https://codereview.chromium.org/23112019/diff/10001/Source/core/html/HTMLElement.cpp#newcode850 Source/core/html/HTMLElement.cpp:850: if (isHTMLTextFormControlElement(this) && !isHTMLTextAreaElement(this)) { Can we get rid ...
7 years, 4 months ago (2013-08-22 23:32:12 UTC) #8
igoroliveira
On 2013/08/22 23:32:12, eseidel wrote: > https://codereview.chromium.org/23112019/diff/10001/Source/core/html/HTMLElement.cpp > File Source/core/html/HTMLElement.cpp (right): > > https://codereview.chromium.org/23112019/diff/10001/Source/core/html/HTMLElement.cpp#newcode850 > ...
7 years, 4 months ago (2013-08-23 18:26:28 UTC) #9
eseidel
https://codereview.chromium.org/23112019/diff/15001/Source/core/html/HTMLElement.cpp File Source/core/html/HTMLElement.cpp (right): https://codereview.chromium.org/23112019/diff/15001/Source/core/html/HTMLElement.cpp#newcode851 Source/core/html/HTMLElement.cpp:851: HTMLInputElement* inputElement = toHTMLInputElement(const_cast<HTMLElement*>(this)); Seems we should just have ...
7 years, 4 months ago (2013-08-23 18:57:48 UTC) #10
igoroliveira
On 2013/08/23 18:57:48, eseidel - vacation until 9.3 wrote: > https://codereview.chromium.org/23112019/diff/15001/Source/core/html/HTMLElement.cpp > File Source/core/html/HTMLElement.cpp (right): ...
7 years, 4 months ago (2013-08-23 21:16:27 UTC) #11
eseidel
lgtm
7 years, 4 months ago (2013-08-23 22:47:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23112019/15001
7 years, 4 months ago (2013-08-23 22:48:00 UTC) #13
commit-bot: I haz the power
7 years, 4 months ago (2013-08-24 00:49:25 UTC) #14
Message was sent while issue was closed.
Change committed as 156664

Powered by Google App Engine
This is Rietveld 408576698